Low-risk cleanup, grouped because none of it is urgent on its own.
Remove the superseded feedback generator. generate_feedback_message (~250 lines in compare_MIDI.py) was replaced by polished_feedback_message and is now referenced only from one comparison cell in Phase1-1.5_summary.ipynb. It also carries a latent bug: at line 1004 the duration direction always reads "longer", because duration_abs_diff was made absolute at line 678 and so is never negative. Either delete it or move it to notebooks/utils/.
Load the Basic Pitch model lazily. evaluation.py calls load_basic_pitch_model() at import time, so every cold start and every test run pays for it even when the submission is pure MIDI and no transcription is needed. Load on first audio input instead.
Lint noise. The advisory flake8 pass reports 267 warnings. The bulk is mechanical:
- trailing whitespace on 120 lines
- 8 unused imports in
evaluation_test.py
- ~37 redundant backslash continuations inside brackets
One formatter pass would clear nearly all of it, and would make the CI advisory output meaningful again.
.gitignore. No .DS_Store entry; two are currently untracked in the working tree.
Notebook size. The three summary notebooks commit about 3.7 MB of outputs (Phase2_summary.ipynb alone is 2.4 MB). Reasonable for a report, but worth a note in notebooks/README.md about whether outputs should be kept on future edits.
Low-risk cleanup, grouped because none of it is urgent on its own.
Remove the superseded feedback generator.
generate_feedback_message(~250 lines incompare_MIDI.py) was replaced bypolished_feedback_messageand is now referenced only from one comparison cell inPhase1-1.5_summary.ipynb. It also carries a latent bug: at line 1004 the duration direction always reads "longer", becauseduration_abs_diffwas made absolute at line 678 and so is never negative. Either delete it or move it tonotebooks/utils/.Load the Basic Pitch model lazily.
evaluation.pycallsload_basic_pitch_model()at import time, so every cold start and every test run pays for it even when the submission is pure MIDI and no transcription is needed. Load on first audio input instead.Lint noise. The advisory flake8 pass reports 267 warnings. The bulk is mechanical:
evaluation_test.pyOne formatter pass would clear nearly all of it, and would make the CI advisory output meaningful again.
.gitignore. No.DS_Storeentry; two are currently untracked in the working tree.Notebook size. The three summary notebooks commit about 3.7 MB of outputs (
Phase2_summary.ipynbalone is 2.4 MB). Reasonable for a report, but worth a note innotebooks/README.mdabout whether outputs should be kept on future edits.