fix: exclude self-loops from traversal context deps

Author: mattrmc1

lib/sdk/server-ai/src/main/java/com/launchdarkly/sdk/server/ai/AgentGraphDefinition.java

@@ -207,12 +207,12 @@ public void traverse(BiFunction<AgentGraphNode, Map<String, Object>, Object> fn,
       if (next == null) {
         next = lowestDegree(order, visited, indeg);
       }
-      visited.add(next);
 
+      // Accumulate deps before marking visited so a self-loop does not count as its own ancestor.
       Set<String> anc = new HashSet<>();
       for (AgentGraphNode parent : getParentNodes(next)) {
         String pk = parent.getKey();
-        if (!visited.contains(pk) || !reachable.contains(pk) || pk.equals(next)) {
+        if (!visited.contains(pk) || !reachable.contains(pk)) {
           continue;
         }
         anc.add(pk);
@@ -222,6 +222,7 @@ public void traverse(BiFunction<AgentGraphNode, Map<String, Object>, Object> fn,
         }
       }
       ancestors.put(next, anc);
+      visited.add(next);
 
       AgentGraphNode nextNode = getNode(next);
       results.put(next, fn.apply(nextNode, scopedCtx(ctx, results, anc)));
@@ -282,8 +283,8 @@ public void reverseTraverse(BiFunction<AgentGraphNode, Map<String, Object>, Obje
       if (next == null) {
         next = lowestDegreeNonRoot(order, visited, outdeg, rootKey);
       }
-      visited.add(next);
 
+      // Accumulate deps before marking visited so a self-loop does not count as its own descendant.
       Set<String> desc = new HashSet<>();
       AgentGraphNode nextNode = getNode(next);
       if (nextNode != null) {
@@ -300,6 +301,7 @@ public void reverseTraverse(BiFunction<AgentGraphNode, Map<String, Object>, Obje
         }
       }
       descendants.put(next, desc);
+      visited.add(next);
       results.put(next, fn.apply(nextNode, scopedCtx(ctx, results, desc)));
 
       for (AgentGraphNode parent : getParentNodes(next)) {

lib/sdk/server-ai/src/test/java/com/launchdarkly/sdk/server/ai/AgentGraphDefinitionTest.java

@@ -417,6 +417,24 @@ public void reverseTraverseHandlesCyclesSafely() {
     assertThat(new HashSet<>(visited), containsInAnyOrder("a", "b"));
   }
 
+  @Test
+  public void selfLoopIsNotIncludedInOwnContext() {
+    // a → b → b (self-loop on b)
+    AgentGraphDefinition graph = buildEnabled("a",
+        new String[][]{{"a", "b"}, {"b", "b"}}, "a", "b");
+    Map<String, Object> initial = new HashMap<>();
+    initial.put("seed", 1);
+
+    Map<String, Set<String>> fwd = captureContextKeys(graph, false, initial);
+    assertThat(fwd.get("b"), containsInAnyOrder("seed", "a"));
+    assertThat(fwd.get("b").contains("b"), is(false));
+
+    Map<String, Set<String>> rev = captureContextKeys(graph, true, initial);
+    assertThat(rev.get("b"), containsInAnyOrder("seed"));
+    assertThat(rev.get("b").contains("b"), is(false));
+    assertThat(rev.get("a"), containsInAnyOrder("seed", "b"));
+  }
+
   @Test
   public void reverseTraverseIsNoOpWhenDisabled() {
     AgentGraphDefinition graph = new AgentGraphDefinition(