From e748217c71d44bb9a9e5138defc79427614464d3 Mon Sep 17 00:00:00 2001 From: Thomas Coratger <60488569+tcoratger@users.noreply.github.com> Date: Thu, 21 May 2026 00:11:21 +0200 Subject: [PATCH] refactor(reqresp): drop defensive finish_write lookup MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The reqresp client opens streams via QuicConnection.open_stream(), which is typed as returning QuicStream — a class that always implements finish_write. The getattr(stream, "finish_write", None) guard at the BlocksByRoot and BlocksByRange sites was dead. The sibling status path already called stream.finish_write() directly, so this aligns the three sites. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../subspecs/networking/client/reqresp_client.py | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/lean_spec/subspecs/networking/client/reqresp_client.py b/src/lean_spec/subspecs/networking/client/reqresp_client.py index adb8d09ff..b032d59c1 100644 --- a/src/lean_spec/subspecs/networking/client/reqresp_client.py +++ b/src/lean_spec/subspecs/networking/client/reqresp_client.py @@ -170,9 +170,7 @@ async def _do_blocks_by_root_request( await stream.write(request_bytes) # Half-close to signal we're done sending. - finish_write = getattr(stream, "finish_write", None) - if finish_write is not None: - await finish_write() + await stream.finish_write() # Read response chunks. # @@ -297,9 +295,7 @@ async def _do_blocks_by_range_request( await stream.write(request_bytes) # Half-close to signal we're done sending. - finish_write = getattr(stream, "finish_write", None) - if finish_write is not None: - await finish_write() + await stream.finish_write() # Read response chunks. # @@ -460,9 +456,7 @@ async def _do_status_request( await stream.write(request_bytes) # Half-close to signal we're done sending. - finish_write = getattr(stream, "finish_write", None) - if finish_write is not None: - await finish_write() + await stream.finish_write() # Read peer's status response. response_data = await stream.read()