All tri for polygonal and polyhedra elements#4464
Open
GiudGiud wants to merge 7 commits into
Open
Conversation
Splits each C0Polygon into the TRI3s defined by its existing triangulation. The per-element subelement container is changed from a fixed-size array to a vector since polygons can produce more than the 6 subelements assumed for 2D/3D primitives, and max_subelems is now computed by also scanning polygons in 2D meshes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> refs idaholab/moose#32159
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> refs idaholab/moose#32159
Splits each C0Polyhedron into the TET4s defined by its existing tetrahedralization. The max_subelems scan is extended to also walk polyhedra in 3D so the per-element subelement vector and global ID offsets accommodate polyhedra that produce more than the 6 tets a HEX8 would. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> refs idaholab/moose#32159
Covers both tetrahedralization paths: a cube (no mid-element node) and a hexagonal prism (mid-element node added to make the split work). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> refs idaholab/moose#32159
roystgnr
added
the
AI Assisted
roystgnr
approved these changes
May 22, 2026
Member
roystgnr
left a comment
roystgnr
left a comment
There was a problem hiding this comment.
Modules test failure unrelated
The AI commits are actually disturbingly good here - how hard was Claude to prompt on this one?
Contributor
Author
|
It wasn't very complicated either but yes I am fairly pleased at them too. I did tell it what to do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have not reviewed it yet hence the draft
EDIT: ok I reviewed it locally and in the git API and it looks good for consideration
If there is such a label, should be marked as
AI assisted