Make atomic matrix init methods public#4465
Open
lindsayad wants to merge 1 commit into
Open
Conversation
I have a matrix which is not rectangular, hence not initializable with the DofMap, and I want to be able to initialize said matrix with hash table based matrix assembly. Making `init_without_preallocation` and `finish_initialization` public allows me to easily do this
jwpeterson
approved these changes
May 22, 2026
roystgnr
approved these changes
May 22, 2026
Member
roystgnr
left a comment
roystgnr
left a comment
There was a problem hiding this comment.
I think these are clean enough to make public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a matrix which is not square, hence not initializable with the DofMap, and I want to be able to initialize said matrix with hash table based matrix assembly. Making
init_without_preallocationandfinish_initializationpublic allows me to easily do this. An alternative would be to add anotherinitoverload but I think we have enough of those