Summary
The pybuild-deps compile failure handler in scripts/konflux_resolve.py does not capture stderr. As a result, subprocess.CalledProcessError.stderr is None, and the script prints None instead of the command failure details.
Required changes
Update the pybuild-deps compile subprocess invocation to capture stderr as text. In the subprocess.CalledProcessError handler, write the captured failure details to sys.stderr. Keep the current non-zero exit behavior and the existing temporary-file cleanup behavior.
Rationale
Users need the pybuild-deps error output to diagnose compilation failures.
Affected area
scripts/konflux_resolve.py- The
pybuild-deps compile invocation in main()
Acceptance criteria
subprocess.run() captures stderr as text for pybuild-deps compile.- A failed command reports its captured stderr to
sys.stderr.
- The script exits with status 1 after the failure.
- The
finally block still removes the temporary sdist list file.
Backlinks
Summary
The
pybuild-deps compilefailure handler inscripts/konflux_resolve.pydoes not capture stderr. As a result,subprocess.CalledProcessError.stderrisNone, and the script printsNoneinstead of the command failure details.Required changes
Update the
pybuild-deps compilesubprocess invocation to capture stderr as text. In thesubprocess.CalledProcessErrorhandler, write the captured failure details tosys.stderr. Keep the current non-zero exit behavior and the existing temporary-file cleanup behavior.Rationale
Users need the
pybuild-depserror output to diagnose compilation failures.Affected area
scripts/konflux_resolve.pypybuild-deps compileinvocation inmain()Acceptance criteria
subprocess.run()captures stderr as text forpybuild-deps compile.sys.stderr.finallyblock still removes the temporary sdist list file.Backlinks