Follow-up from PR #1068 review (@PeterJhongLinksys). Non-blocking / minor.
usp_pdf_service._buildMeshTopology now prints n.connectedClients.length for each node's client count, but the legacy NodeUIModel.connectedDeviceCount was active-only. connectedClients includes both online and offline clients, so the PDF report's per-node client count now over-reports vs the pre-migration behavior.
File: lib/page/_shared/services/usp_pdf_service.dart (~L865, in _buildMeshTopology)
Impact: minor/cosmetic — the PDF node table shows a larger client count than before (offline clients included). No functional effect.
Suggested fix: count only active clients to match legacy semantics, e.g. n.connectedClients.where((c) => c.isActive).length (or decide the online+offline count is actually desired and document it).
Split out of PR #1068 review (non-blocking follow-up).
Follow-up from PR #1068 review (@PeterJhongLinksys). Non-blocking / minor.
usp_pdf_service._buildMeshTopologynow printsn.connectedClients.lengthfor each node's client count, but the legacyNodeUIModel.connectedDeviceCountwas active-only.connectedClientsincludes both online and offline clients, so the PDF report's per-node client count now over-reports vs the pre-migration behavior.File: lib/page/_shared/services/usp_pdf_service.dart (~L865, in
_buildMeshTopology)Impact: minor/cosmetic — the PDF node table shows a larger client count than before (offline clients included). No functional effect.
Suggested fix: count only active clients to match legacy semantics, e.g.
n.connectedClients.where((c) => c.isActive).length(or decide the online+offline count is actually desired and document it).Split out of PR #1068 review (non-blocking follow-up).