Fix falling tests: test_get_nb_node and test_update_nb_node. Add new test test_get_nb_with_lke_cluster

Author: psnoch-akamai

test/integration/filters/fixtures.py

@@ -1,6 +1,8 @@
 from test.integration.conftest import get_region
 from test.integration.helpers import get_test_label
-
+from linode_api4 import (
+    LKEClusterControlPlaneOptions,
+)
 import pytest
 
 
@@ -35,3 +37,27 @@ def lke_cluster_instance(test_linode_client):
     yield cluster
 
     cluster.delete()
+
+
+@pytest.fixture(scope="package")
+def lke_cluster(test_linode_client):
+    node_type = "g6-dedicated-4"  # g6-standard-1
+    version = test_linode_client.lke.versions()[0]
+
+    region = get_region(test_linode_client, {"Kubernetes"})
+
+    node_pool = test_linode_client.lke.node_pool(node_type, 3)
+    label = get_test_label() + "_cluster"
+
+    cluster = test_linode_client.lke.cluster_create(
+        region,
+        label,
+        version,
+        [node_pool],
+        apl_enabled=True,
+        control_plane=LKEClusterControlPlaneOptions(high_availability=True),
+    )
+
+    yield cluster
+
+    cluster.delete()

test/integration/models/nodebalancer/test_nodebalancer.py

@@ -6,7 +6,16 @@
     get_region,
     get_token,
 )
-from test.integration.helpers import get_test_label
+from test.integration.helpers import (
+    get_test_label,
+    wait_for_condition,
+)
+from test.integration.filters.fixtures import (
+    lke_cluster,
+)
+from linode_api4.objects import (
+    LKECluster,
+)
 
 import pytest
 
@@ -184,10 +193,43 @@ def test_get_nb(test_linode_client, create_nb):
     )
 
     assert nb.id == create_nb.id
-    assert nb.type == 'common'
+    assert nb.type == "common"
     assert nb.lke_cluster is None
 
 
+def find_related_nodebalancer(client, cluster: LKECluster):
+    nbs = client.nodebalancers()
+    for nb in nbs:
+        if nb.lke_cluster is not None and nb.lke_cluster.id == cluster.id:
+            return nb.id
+    return 0
+
+
+def is_related_nodebalancer_exist(client, cluster: LKECluster):
+    if find_related_nodebalancer(client, cluster):
+        return True
+    return False
+
+
+def test_get_nb_with_lke_cluster(test_linode_client, lke_cluster):
+    wait_for_condition(
+        10,
+        600,
+        is_related_nodebalancer_exist,
+        test_linode_client,
+        lke_cluster,
+    )
+    nb = test_linode_client.load(
+        NodeBalancer,
+        find_related_nodebalancer(test_linode_client, lke_cluster),
+    )
+    assert nb.type == "common"
+    assert nb.lke_cluster is not None
+    assert nb.lke_cluster.label is not None
+    assert nb.lke_cluster.type == "lkecluster"
+    assert "/lke/clusters/" in str(nb.lke_cluster.url)
+
+
 def test_update_nb(test_linode_client, create_nb):
     nb = test_linode_client.load(
         NodeBalancer,
@@ -207,7 +249,7 @@ def test_update_nb(test_linode_client, create_nb):
 
     assert new_label == nb_updated.label
     assert 5 == nb_updated.client_udp_sess_throttle
-    assert nb.type == 'common'
+    assert nb.type == "common"
     assert nb.lke_cluster is None
 
 
@@ -231,15 +273,32 @@ def test_create_nb_node(
 
 
 @pytest.mark.smoke
-def test_get_nb_node(test_linode_client, create_nb_config):
-    test_linode_client.load(
+def test_get_nb_node(
+    test_linode_client, create_nb_config, linode_with_private_ip
+):
+    address = [
+        a for a in linode_with_private_ip.ipv4 if re.search("192.168.+", a)
+    ][0]
+    create_nb_config.node_create(
+        "node_test", address + ":80", weight=50, mode="accept"
+    )
+    node = test_linode_client.load(
         NodeBalancerNode,
         create_nb_config.nodes[0].id,
         (create_nb_config.id, create_nb_config.nodebalancer_id),
     )
+    assert "node_test" == node.label
 
 
-def test_update_nb_node(test_linode_client, create_nb_config):
+def test_update_nb_node(
+    test_linode_client, create_nb_config, linode_with_private_ip
+):
+    address = [
+        a for a in linode_with_private_ip.ipv4 if re.search("192.168.+", a)
+    ][0]
+    create_nb_config.node_create(
+        "node_test", address + ":80", weight=50, mode="accept"
+    )
     config = test_linode_client.load(
         NodeBalancerConfig,
         create_nb_config.id,