Skip to content

Commit fd200cf

Browse files
fix: prevent GitHub Actions script injection (#718)
1 parent 6f4c991 commit fd200cf

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

.github/workflows/e2e-test-pr.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,13 @@ jobs:
112112
run: |
113113
timestamp=$(date +'%Y%m%d%H%M')
114114
report_filename="${timestamp}_sdk_test_report.xml"
115-
make test-int RUN_DB_FORK_TESTS=${{ github.event.inputs.run_db_fork_tests }} RUN_DB_TESTS=${{ github.event.inputs.run_db_tests }} RUN_ACLP_LOGS_STREAM_TESTS=${{ github.event.inputs.run_aclp_logs_stream_tests }} TEST_ARGS="--junitxml=${report_filename}" TEST_SUITE="${{ github.event.inputs.test_suite }}"
115+
make test-int RUN_DB_FORK_TESTS="$RUN_DB_FORK_TESTS" RUN_DB_TESTS="$RUN_DB_TESTS" RUN_ACLP_LOGS_STREAM_TESTS="$RUN_ACLP_LOGS_STREAM_TESTS" TEST_ARGS="--junitxml=${report_filename}" TEST_SUITE="$TEST_SUITE"
116116
env:
117117
LINODE_TOKEN: ${{ secrets.LINODE_TOKEN }}
118+
RUN_DB_FORK_TESTS: ${{ github.event.inputs.run_db_fork_tests }}
119+
RUN_DB_TESTS: ${{ github.event.inputs.run_db_tests }}
120+
RUN_ACLP_LOGS_STREAM_TESTS: ${{ github.event.inputs.run_aclp_logs_stream_tests }}
121+
TEST_SUITE: ${{ github.event.inputs.test_suite }}
118122

119123
- name: Upload test results
120124
if: always() && github.repository == 'linode/linode_api4-python' && (github.event_name == 'pull_request' || (github.event_name == 'workflow_dispatch' && inputs.test_report_upload == 'true'))

.github/workflows/e2e-test.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,13 @@ jobs:
107107
run: |
108108
timestamp=$(date +'%Y%m%d%H%M')
109109
report_filename="${timestamp}_sdk_test_report.xml"
110-
make test-int RUN_DB_FORK_TESTS=${{ github.event.inputs.run_db_fork_tests }} RUN_DB_TESTS=${{ github.event.inputs.run_db_tests }} RUN_ACLP_LOGS_STREAM_TESTS=${{ github.event.inputs.run_aclp_logs_stream_tests }} TEST_SUITE="${{ github.event.inputs.test_suite }}" TEST_ARGS="--junitxml=${report_filename}"
110+
make test-int RUN_DB_FORK_TESTS="$RUN_DB_FORK_TESTS" RUN_DB_TESTS="$RUN_DB_TESTS" RUN_ACLP_LOGS_STREAM_TESTS="$RUN_ACLP_LOGS_STREAM_TESTS" TEST_SUITE="$TEST_SUITE" TEST_ARGS="--junitxml=${report_filename}"
111111
env:
112112
LINODE_TOKEN: ${{ env.LINODE_TOKEN }}
113+
RUN_DB_FORK_TESTS: ${{ github.event.inputs.run_db_fork_tests }}
114+
RUN_DB_TESTS: ${{ github.event.inputs.run_db_tests }}
115+
RUN_ACLP_LOGS_STREAM_TESTS: ${{ github.event.inputs.run_aclp_logs_stream_tests }}
116+
TEST_SUITE: ${{ github.event.inputs.test_suite }}
113117

114118
- name: Upload Test Report as Artifact
115119
if: always()

0 commit comments

Comments
 (0)