Skip to content

fix: add X-Deepin-Singleton flag to desktop file (#392841)#709

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:task-392841-add-x-deepin-singleton-flag
Jul 17, 2026
Merged

fix: add X-Deepin-Singleton flag to desktop file (#392841)#709
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:task-392841-add-x-deepin-singleton-flag

Conversation

@add-uos

@add-uos add-uos commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Add X-Deepin-Singleton=true to desktop file to mark the application as a singleton app. This allows AM to identify singleton apps and inform Treeland to skip the splash screen for these apps.

Refs: https://pms.uniontech.com/task-view-392841.html

Summary by Sourcery

Mark deepin-devicemanager as a singleton application via its desktop file to enable correct handling by the application manager and Treeland.

New Features:

  • Mark the deepin-devicemanager application as a singleton so the environment can treat it accordingly.

Enhancements:

  • Update the desktop entry metadata to allow the application manager and Treeland to skip splash screens for singleton apps.

@sourcery-ai

sourcery-ai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds the X-Deepin-Singleton flag to the deepin-devicemanager desktop entry so AM can treat it as a singleton app and Treeland can skip the splash screen.

File-Level Changes

Change Details Files
Mark the Deepin Device Manager desktop entry as a singleton application via a new desktop file key.
  • Add X-Deepin-Singleton=true key to the desktop entry to declare the app as singleton.
  • Ensure the singleton flag is placed alongside other desktop entry keys to be correctly parsed by AM/Treeland.
deepin-devicemanager/assets/deepin-devicemanager.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Add X-Deepin-Singleton=true to desktop file to mark the
application as a singleton app.

为单例应用的desktop文件添加X-Deepin-Singleton=true标识。

Log: 添加单例应用标识
PMS: TASK-392841
Influence: AM能识别单例应用,Treeland不再为单例应用显示快速启动画面
@add-uos
add-uos force-pushed the task-392841-add-x-deepin-singleton-flag branch from c36f8fa to 5503560 Compare July 17, 2026 02:42
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码为桌面快捷方式配置添加了单例运行属性,修改简单且符合规范
逻辑正确无安全风险,功能实现完善

■ 【详细分析】

  • 1.语法逻辑(基本正确)✓

在 deepin-devicemanager.desktop 文件中新增了 X-Deepin-Singleton=true 属性,符合 Desktop Entry 规范及 Deepin 扩展字段格式
潜在问题:无
建议:无

  • 2.代码质量(优秀)✓

修改位置准确,配置项命名规范,直接作用于应用启动行为
潜在问题:无
建议:无

  • 3.代码性能(无性能问题)✓

配置文件的修改不影响运行时性能,单例模式反而可能减少重复启动带来的资源消耗
潜在问题:无
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次修改仅涉及桌面配置文件单例属性的添加,不存在任何外部输入处理或敏感操作,无攻击面

  • 建议:无

■ 【改进建议代码示例】

diff --git a/deepin-devicemanager/assets/deepin-devicemanager.desktop b/deepin-devicemanager/assets/deepin-devicemanager.desktop
index 38c37703..7b3f39bb 100644
--- a/deepin-devicemanager/assets/deepin-devicemanager.desktop
+++ b/deepin-devicemanager/assets/deepin-devicemanager.desktop
@@ -10,6 +10,7 @@ Terminal=false
 Type=Application
 X-Ayatana-Desktop-Shortcuts=deepin-devicemanager
 X-Deepin-Vendor=deepin
+X-Deepin-Singleton=true
 
 # Translations:
 # Do not manually modify!

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
lzwind merged commit 312832e into linuxdeepin:master Jul 17, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants