Skip to content

fix: add X-Deepin-Singleton flag to desktop file (#392841)#211

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:task-392841-add-x-deepin-singleton-flag
Jul 17, 2026
Merged

fix: add X-Deepin-Singleton flag to desktop file (#392841)#211
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:task-392841-add-x-deepin-singleton-flag

Conversation

@add-uos

@add-uos add-uos commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Add X-Deepin-Singleton=true to desktop file to mark the application as a singleton app. This allows AM to identify singleton apps and inform Treeland to skip the splash screen for these apps.

Refs: https://pms.uniontech.com/task-view-392841.html

Summary by Sourcery

Bug Fixes:

  • Mark deepin-diskmanager as a singleton application via desktop entry metadata to ensure splash screen is skipped appropriately.

Add X-Deepin-Singleton=true to desktop file to mark the
application as a singleton app.

为单例应用的desktop文件添加X-Deepin-Singleton=true标识。

Log: 添加单例应用标识
PMS: TASK-392841
Influence: AM能识别单例应用,Treeland不再为单例应用显示快速启动画面
@sourcery-ai

sourcery-ai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Marks deepin-diskmanager as a singleton application by adding the X-Deepin-Singleton flag to its desktop entry, enabling the app manager and Treeland to treat it as a splashless singleton app.

File-Level Changes

Change Details Files
Mark the disk manager desktop entry as a singleton application via a new X-Deepin-Singleton flag.
  • Added X-Deepin-Singleton=true key to the desktop entry to declare the app as singleton.
  • Ensured the flag is present in the main application desktop file used by the app manager and Treeland.
application/assets/deepin-diskmanager.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码正确添加了应用单例运行属性配置,符合桌面环境规范
逻辑清晰且无任何安全风险,配置项合理有效

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

deepin-diskmanager.desktop 文件中新增 X-Deepin-Singleton=true 配置项,符合 .desktop 文件的标准键值对语法格式,无语法错误。
潜在问题:无
建议:无需修改

  • 2.代码质量(良好)✓

配置项命名规范,位置放置合理,能够明确表达应用需要单例运行的意图,提升了应用配置的完整性。
潜在问题:无
建议:无需修改

  • 3.代码性能(无性能问题)✓

新增配置项仅影响应用启动时的行为控制,不涉及运行时性能开销。
建议:无需修改

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次修改仅为配置文件新增单例属性,不涉及任何用户输入处理、外部命令调用或敏感信息操作,无攻击面。
建议:无需修改

■ 【改进建议代码示例】

diff --git a/application/assets/deepin-diskmanager.desktop b/application/assets/deepin-diskmanager.desktop
index 06cbf404..c504e9fd 100644
--- a/application/assets/deepin-diskmanager.desktop
+++ b/application/assets/deepin-diskmanager.desktop
@@ -8,5 +8,6 @@ StartupNotify=true
 TryExec=deepin-diskmanager
 Type=Application
 X-Deepin-Vendor=deepin
+X-Deepin-Singleton=true
 
 # Automatically generate translations

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
lzwind merged commit 26ac7eb into linuxdeepin:master Jul 17, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants