From c5851a75c0d5d39ede085defb376a0124276d284 Mon Sep 17 00:00:00 2001 From: IlyaVrum Date: Mon, 24 Aug 2026 03:42:29 +0200 Subject: [PATCH] keybindings: allow screenshot keys while a menu is open Area/window/clipboard screenshot keys were registered with ActionMode.NORMAL, so pressing e.g. Print with any menu or applet popup open did nothing - while the full-screen SCREENSHOT key (ALL) and the volume keys worked fine in the same situation. Capturing the screen with a popup open is a legitimate and common request, and the pickers in js/ui/screenshot.js handle running on top of an existing modal. Register all screenshot media keys with ActionMode.ALL. Co-Authored-By: Claude Fable 5 --- js/ui/keybindings.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/js/ui/keybindings.js b/js/ui/keybindings.js index 768ed51332..f36b747519 100644 --- a/js/ui/keybindings.js +++ b/js/ui/keybindings.js @@ -43,13 +43,15 @@ const MEDIA_KEYS = [ { key: MK.REPEAT, mode: Cinnamon.ActionMode.ALL }, { key: MK.RANDOM, mode: Cinnamon.ActionMode.ALL }, - // Screenshots + // Screenshots: ALL, not NORMAL - taking a screenshot is useful precisely + // while a menu or applet popup is open, and full-screen Print already + // worked there. { key: MK.SCREENSHOT, mode: Cinnamon.ActionMode.ALL }, - { key: MK.SCREENSHOT_CLIP, mode: Cinnamon.ActionMode.NORMAL }, - { key: MK.WINDOW_SCREENSHOT, mode: Cinnamon.ActionMode.NORMAL }, - { key: MK.WINDOW_SCREENSHOT_CLIP, mode: Cinnamon.ActionMode.NORMAL }, - { key: MK.AREA_SCREENSHOT, mode: Cinnamon.ActionMode.NORMAL }, - { key: MK.AREA_SCREENSHOT_CLIP, mode: Cinnamon.ActionMode.NORMAL }, + { key: MK.SCREENSHOT_CLIP, mode: Cinnamon.ActionMode.ALL }, + { key: MK.WINDOW_SCREENSHOT, mode: Cinnamon.ActionMode.ALL }, + { key: MK.WINDOW_SCREENSHOT_CLIP, mode: Cinnamon.ActionMode.ALL }, + { key: MK.AREA_SCREENSHOT, mode: Cinnamon.ActionMode.ALL }, + { key: MK.AREA_SCREENSHOT_CLIP, mode: Cinnamon.ActionMode.ALL }, // Touchpad { key: MK.TOUCHPAD, mode: Cinnamon.ActionMode.NORMAL },