Fix EVM account lookup without balance rows#19
Open
crossagent-production-app[bot] wants to merge 1 commit into
Open
Fix EVM account lookup without balance rows#19crossagent-production-app[bot] wants to merge 1 commit into
crossagent-production-app[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #17
Change:
ApiSrv.AccountsCursorso EVM account lookups useevm_accountsas the source of truth and left joinbalance_accounts; accounts without a balance row now return with balance0instead of being filtered out.COALESCE(balance_accounts.balance, 0)expression.0x63c4545ac01c77cc74044f25b8edea3880224577with no balance row and another unrelated EVM account row.Objective Evidence:
go test $(rg --files plugins/evm/dao -g'*.go' -g'!*_test.go') plugins/evm/dao/api_accounts_test.go -run TestAccountsCursorIncludesAccountWithoutBalance -count=1-> passed.https://test-explorer.heima.network/api/plugin/evm/accountsaccess from this environment returns HTTP 401 Vercel Authentication, so external browser/API reproduction is blocked by deployment protection; the local regression reproduces the backend request shape.Visual Evidence:
Reviewer:
Risks / Not Covered:
go test ./plugins/evm/daois blocked in this worktree by existing integration test bootstrap requiringconfigs/config.yaml, MySQL, and Redis.