Skip to content

Improve dark-theme contract verification contrast#23

Merged
YoshiyukiSakura merged 1 commit into
crossagentfrom
worktree/task_367aaf899fac4aa3
May 22, 2026
Merged

Improve dark-theme contract verification contrast#23
YoshiyukiSakura merged 1 commit into
crossagentfrom
worktree/task_367aaf899fac4aa3

Conversation

@crossagent-production-app
Copy link
Copy Markdown

@crossagent-production-app crossagent-production-app Bot commented May 22, 2026

Related to #20.

Summary

  • Improves dark-theme contrast for the EVM contract verification form labels, select values, placeholders, radio states, and action buttons.
  • Scopes the contrast overrides to the contract verification form.

Verification

  • npm run lint passed with existing unrelated warnings.
  • npx prettier './src/components/contract/verify.tsx' './src/styles/globals.css' --check passed.
  • node -e '<mocked Heima contract page validation>' # playwright validation passed and captured /tmp/crossagent-issue-20-final-ui.png.

Delivery Evidence Summary

Change:

  • Scoped dark-theme contrast overrides to the EVM contract verification form.
  • Made Compiler Type, Include nightly builds, select values, placeholders, radio states, Verify Guide, and Reset readable on the dark panel.

Objective Evidence:

  • npm run lint passed with existing unrelated warnings in Footer.test.tsx and sub/account/[id].tsx.
  • npx prettier './src/components/contract/verify.tsx' './src/styles/globals.css' --check passed.
  • node -e '<mocked Heima contract page validation>' # playwright validation passed; it loaded /contract/0x1ac62f1c2d828476a5d784e850a700dc1f17e0be, selected Single file mode, asserted required controls, checked 15.64:1 contrast on key labels/buttons, and wrote /tmp/crossagent-issue-20-final-ui.png.

Visual Evidence:

  • final dark-theme contract verification form

Reviewer:

Risks / Not Covered:

  • Protected Heima preview URL requires Vercel authentication, so browser validation used local Next.js with mocked API responses for the same unverified contract route.
  • Existing app console warnings for unlabeled HeroUI controls and Next head script remain outside this contrast-only fix.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
subscan-essentials Ready Ready Preview, Comment May 22, 2026 8:00am
subscan-essentials-ui-react Ready Ready Preview, Comment May 22, 2026 8:00am

Request Review

@YoshiyukiSakura
Copy link
Copy Markdown
Contributor

Temporary image host for CrossAgent formal evidence upload. Formal delivery evidence must be published by the CrossAgent GitHub App separately.\n\ncrossagent-issue-20-final-ui.png

@crossagent-production-app
Copy link
Copy Markdown
Author

crossagent-production-app Bot commented May 22, 2026

Delivery Evidence Summary

Change:

  • Scoped dark-theme contrast overrides to the EVM contract verification form.
  • Improved readability for Compiler Type, Include nightly builds, select values, placeholders, radio states, Verify Guide, and Reset on the dark panel.

Objective Evidence:

  • npm run lint exit code 0, passed: Next lint completed; remaining warnings are pre-existing in Footer.test.tsx and sub/account/[id].tsx.
  • npx prettier './src/components/contract/verify.tsx' './src/styles/globals.css' --check exit code 0, passed: Touched files match repository formatting.
  • node - <<'NODE' ... NODE # playwright e2e final screenshot validation exit code 0, passed: Browser validation loaded the contract route in dark mode with mocked Heima API data, selected Single file mode, asserted the required verification controls, and captured the final UI state.

Visual Evidence:

  • final dark-theme contract verification form
  • Final dark-theme contract verification form after the Playwright E2E validation.

Reviewer:

Risks / Not Covered:

  • Authentication-gated Heima preview access was mirrored with local Next.js and mocked API responses for the same unverified contract route.
  • Existing app console warnings for unlabeled HeroUI controls and Next head script usage remain outside this contrast-only change.

Generated at: 2026-05-22T08:10:06.092Z

@crossagent-production-app
Copy link
Copy Markdown
Author

Completion-check Playwright E2E Evidence

Objective Evidence:

  • npm exec playwright -- screenshot --browser chromium --wait-for-timeout 12000 http://localhost:3020/contract/0x1ac62f1c2d828476a5d784e850a700dc1f17e0be /tmp/subscan-essentials-contract-e2e.png exit code 0, passed: direct Playwright browser validation opened the local contract route and captured a nonblank rendered page.
  • git restore -- ui-react/public/__ENV.js && git status --short exit code 0, passed: dev-server generated ui-react/public/__ENV.js was restored and the worktree is clean.

Visual Evidence:

subscan-essentials-contract-e2e.png
subscan-essentials-contract-e2e.png

Known Risks:

@YoshiyukiSakura YoshiyukiSakura merged commit ab60480 into crossagent May 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants