Skip to content

Verify contract source-code lookup#25

Open
crossagent-production-app[bot] wants to merge 1 commit into
crossagentfrom
worktree/task_3c6007ce0ac94bb9
Open

Verify contract source-code lookup#25
crossagent-production-app[bot] wants to merge 1 commit into
crossagentfrom
worktree/task_3c6007ce0ac94bb9

Conversation

@crossagent-production-app
Copy link
Copy Markdown

Addresses #24

Summary

  • Added verified_source filtering to /api/plugin/evm/contracts so the explorer can list contracts that are verified and have stored source code.
  • Added contract UI states that make missing uploaded source explicit and expose a "Verified source only" list filter.

Verification

  • go test ./plugins/evm/http
  • npx prettier --check src/components/contract/contractTable.tsx src/components/contract/info.tsx 'src/pages/contract/[id].tsx'
  • node - <<'NODE' ... require('playwright') ... NODE against http://localhost:3000, mocked contract APIs, and captured /tmp/subscan-contract-source-final.png

Delivery Evidence Summary

Change:

  • Contracts API accepts verified_source: true and returns only contracts where verify_status = "verified" and source_code is present.
  • Contract list UI can filter to verified source-backed rows, and unverified detail pages say source code has not been uploaded.

Objective Evidence:

  • Backend HTTP package tests pass: go test ./plugins/evm/http.
  • Changed contract TSX files pass Prettier check.
  • Playwright browser validation passes against the final UI state with mocked contract data.

Visual Evidence:

  • Visual evidence will be attached immediately after PR creation through gh attach and this body will be updated with the rendered image.

Reviewer:

Risks / Not Covered:

  • go test ./plugins/evm/dao is still blocked locally by the existing plugins/evm/dao/storage_test.go MySQL/config bootstrap requirement.
  • npm run build compiles, then fails on existing static prerender routes with NextRouter was not mounted; the contract flow was validated through next dev plus Playwright.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
subscan-essentials Ready Ready Preview, Comment May 22, 2026 10:11am
subscan-essentials-ui-react Ready Ready Preview, Comment May 22, 2026 10:11am

Request Review

@crossagent-production-app
Copy link
Copy Markdown
Author

Attachments

Playwright evidence: contract source empty state

subscan-contract-source-screenshot.png
subscan-contract-source-screenshot.png

@crossagent-production-app
Copy link
Copy Markdown
Author

crossagent-production-app Bot commented May 22, 2026

Delivery Evidence Summary

Change:

  • Adds the contract source-code lookup and display handling needed for the Heima test explorer contract-detail validation path.

Objective Evidence:

  • npx playwright test tmp/evidence/contract-source-e2e.spec.js exit code 0, completed: E2E/browser validation captured the final Contract Source tab state.
  • curl -I -L --max-time 30 https://tmpfiles.org/dl/wzwPg0CoWEbO/subscan-contract-source-screenshot.png exit code 0, completed: Remote visual evidence returned HTTP 200 with content-type image/png before publication.

Visual Evidence:

  • Contract source-code empty state evidence

Reviewer:

  • Repo Intake Evidence Publisher verified the E2E command record, clean worktree, public image reachability, and PR-comment render for the delivery evidence package.

Risks / Not Covered:

  • Covers the browser-visible contract source-code detail path and evidence publication gates for PR Verify contract source-code lookup #25. Root-cause breadth beyond the validated contract-detail workflow remains for normal reviewer assessment.

Generated at: 2026-05-22T23:57:26.201Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant