fix: open ai llm prewarm#3822
Closed
Pulkit0729 wants to merge 1 commit into
Closed
Conversation
|
|
marctorsoc
reviewed
Nov 10, 2025
| # but we print the results for visibility | ||
| print(f"Prewarm Test Results:") | ||
| print(f" Without prewarm: {ttft_no_prewarm:.3f}s") | ||
| print(f" With prewarm: {ttft_with_prewarm:.3f}s") |
Contributor
There was a problem hiding this comment.
Thanks for your contribution! I hope the livekit team reviews this and gets it in. Looks like a must. To facilitate review, I would recommend:
- run ruff
- move into a method everything from
chat_ctx = llm.ChatContext()toawait llm_no_prewarm.aclose(). It is likely that this can be reused for test_llm_prewarm of other providers (gemini, etc) - move into a constant the LLM you're choosing. In this case: gpt-4o-mini
Pulkit0729
force-pushed
the
llm-prewarm
branch
from
November 13, 2025 13:43
10f3b22 to
2909d8e
Compare
Pulkit0729
force-pushed
the
llm-prewarm
branch
from
November 13, 2025 13:44
2909d8e to
171171c
Compare
Author
|
@marctorsoc Thanks for the review, updated the PR |
Member
|
closed in favor of #6484 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a draft PR for #3240
PS: The test file was create by copilot, but i have testest is thoroughly.