Follow-up from #67 / #74.
The examples/upload-modes/ browser E2E (TestUploadModesE2E and friends) is gated behind LVT_UPLOAD_MODES_E2E=1 + LVT_LOCAL_CLIENT, so it currently runs nowhere in CI:
build.yml's e2e job runs cd e2e && go test ./... — only the e2e/ package, never examples/....- The test's own skip message points here: "set LVT_UPLOAD_MODES_E2E=1 and LVT_LOCAL_CLIENT to run the browser e2e (docs#67)".
What's needed
- A CI job (or an addition to the existing
e2e job) that runs the upload-modes example browser test with a real client bundle.
- Provide
LVT_LOCAL_CLIENT (a built livetemplate-client.browser.js) — the example serves the published CDN client by default, but the gated E2E needs a local bundle. Decide whether to build the client in CI or pin a published artifact.
- Set
LVT_UPLOAD_MODES_E2E=1 for that job and ensure a headless Chromium is available (the cross-repo CI uses a Docker-chrome remote allocator; the docs e2e job uses google-chrome-stable on the runner).
Acceptance
- The upload-modes four-mode E2E runs on PRs touching the example, and asserts (per the test) that the Proxied upload stages zero files on local disk.
Follow-up from #67 / #74.
The
examples/upload-modes/browser E2E (TestUploadModesE2Eand friends) is gated behindLVT_UPLOAD_MODES_E2E=1+LVT_LOCAL_CLIENT, so it currently runs nowhere in CI:build.yml'se2ejob runscd e2e && go test ./...— only thee2e/package, neverexamples/....What's needed
e2ejob) that runs theupload-modesexample browser test with a real client bundle.LVT_LOCAL_CLIENT(a builtlivetemplate-client.browser.js) — the example serves the published CDN client by default, but the gated E2E needs a local bundle. Decide whether to build the client in CI or pin a published artifact.LVT_UPLOAD_MODES_E2E=1for that job and ensure a headless Chromium is available (the cross-repo CI uses a Docker-chrome remote allocator; the docse2ejob usesgoogle-chrome-stableon the runner).Acceptance