Skip to content

Commit 58c10be

Browse files
KSemenenkoclaude
andcommitted
Drop the deleted partition query, join budget and filtered sizing tests from the coverage contract
4207a08 deleted PartitionQueryGrantTests, PartitionQueryPublicBudgetTests, the SQL inner join budget/deadline tests and the filtered-search sizing sources with the operation limits, but the functional coverage contract, the product contributor registry and the manifest expansion identities still listed them. The manifest check then expected 25 query cases against 22 contributor rows and 37 candidate identities against 30. - The contract lists 19 contributor sources, 8 classes and 21 exact cases, and its KeyLoad.Query source inventory follows the current tree (266 files, including the ScriptDom syntax and keyset page sources added on 2026-10-23). - The registry has 41 unit rows; the coverage script's fixed counts and class list match the contract. - Seven expansion identities of deleted join budget/deadline methods are gone. Verification: unit tests build with -warnaserror; dotnet format verify; governance PASS; locally AcCq045, AcCq046 and ImagesProduceClosedManifestAndRejectTamperingWithoutReplacingEvidence pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent e33c722 commit 58c10be

5 files changed

Lines changed: 15 additions & 95 deletions

File tree

‎scripts/Features/CodeQuality/functional-coverage.contract.json‎

Lines changed: 9 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@
8080
"src/KeyLoad.Query/QueryExecution/Execution/PartitionQuery/PartitionQueryRemoteExecution.cs",
8181
"src/KeyLoad.Query/QueryExecution/Execution/PartitionQuery/PartitionQueryRetention.cs",
8282
"src/KeyLoad.Query/QueryExecution/Execution/QueryCursorExecution.cs",
83+
"src/KeyLoad.Query/QueryExecution/Execution/QueryKeysetPage.cs",
8384
"src/KeyLoad.Query/QueryExecution/Execution/QueryProjectionRedactions.cs",
8485
"src/KeyLoad.Query/QueryExecution/Execution/QueryReadCutObservationDispatch.cs",
8586
"src/KeyLoad.Query/QueryExecution/Execution/QueryRowProjection.cs",
@@ -114,6 +115,14 @@
114115
"src/KeyLoad.Query/QueryExecution/Parsing/ScriptDom/ScriptDomWindowLowering.cs",
115116
"src/KeyLoad.Query/QueryExecution/Parsing/SqlGraphPathParser.cs",
116117
"src/KeyLoad.Query/QueryExecution/Parsing/SqlGraphSearchParser.cs",
118+
"src/KeyLoad.Query/QueryExecution/Parsing/Syntax/ScriptDomBoundedReader.cs",
119+
"src/KeyLoad.Query/QueryExecution/Parsing/Syntax/ScriptDomCheckedTokens.cs",
120+
"src/KeyLoad.Query/QueryExecution/Parsing/Syntax/ScriptDomErrors.cs",
121+
"src/KeyLoad.Query/QueryExecution/Parsing/Syntax/ScriptDomParsingObservation.cs",
122+
"src/KeyLoad.Query/QueryExecution/Parsing/Syntax/ScriptDomSlots.cs",
123+
"src/KeyLoad.Query/QueryExecution/Parsing/Syntax/ScriptDomSlotVisitor.cs",
124+
"src/KeyLoad.Query/QueryExecution/Parsing/Syntax/ScriptDomSyntax.cs",
125+
"src/KeyLoad.Query/QueryExecution/Parsing/Syntax/ScriptDomTokenBounds.cs",
117126
"src/KeyLoad.Query/QueryExecution/Queries/EventEntityRefJoinExecutor.cs",
118127
"src/KeyLoad.Query/QueryExecution/Queries/PredicateEvaluator.cs",
119128
"src/KeyLoad.Query/QueryExecution/Queries/PreparedQuery.cs",
@@ -171,7 +180,6 @@
171180
"src/KeyLoad.Query/Search/Admission/AnnSearchMode.cs",
172181
"src/KeyLoad.Query/Search/Admission/AnnSearchResult.cs",
173182
"src/KeyLoad.Query/Search/Admission/AnnWorkBudget.cs",
174-
"src/KeyLoad.Query/Search/Admission/FilteredSearchRequestSizer.cs",
175183
"src/KeyLoad.Query/Search/Admission/PackedAnnAdmission.cs",
176184
"src/KeyLoad.Query/Search/Admission/PackedAnnIdentityReservations.cs",
177185
"src/KeyLoad.Query/Search/Admission/PackedAnnReservations.cs",
@@ -232,7 +240,6 @@
232240
"src/KeyLoad.Query/Search/Queries/Ann/SearchEngine.cs",
233241
"src/KeyLoad.Query/Search/Queries/AnnLifetimeProjection.cs",
234242
"src/KeyLoad.Query/Search/Queries/FilteredSearch/FilteredSearchBranch.cs",
235-
"src/KeyLoad.Query/Search/Queries/FilteredSearch/FilteredSearchCountingStream.cs",
236243
"src/KeyLoad.Query/Search/Queries/FilteredSearch/FilteredSearchErrors.cs",
237244
"src/KeyLoad.Query/Search/Queries/GlobalBranch/GlobalBranchByteAdmission.cs",
238245
"src/KeyLoad.Query/Search/Queries/GlobalBranch/GlobalBranchOrder.cs",
@@ -285,10 +292,8 @@
285292
"tests/KeyLoad.UnitTests/QueryExecution/Cases/Partition/PartitionQueryAuthorizationTests.cs",
286293
"tests/KeyLoad.UnitTests/QueryExecution/Cases/Partition/PartitionQueryCancellationTests.cs",
287294
"tests/KeyLoad.UnitTests/QueryExecution/Cases/Partition/PartitionQueryContractTests.cs",
288-
"tests/KeyLoad.UnitTests/QueryExecution/Cases/Partition/PartitionQueryGrantTests.cs",
289295
"tests/KeyLoad.UnitTests/QueryExecution/Cases/Partition/PartitionQueryMergeTests.cs",
290296
"tests/KeyLoad.UnitTests/QueryExecution/Cases/Partition/PartitionQueryPublicAuthorizationTests.cs",
291-
"tests/KeyLoad.UnitTests/QueryExecution/Cases/Partition/PartitionQueryPublicBudgetTests.cs",
292297
"tests/KeyLoad.UnitTests/QueryExecution/Cases/Partition/PartitionQueryPublicContractTests.cs",
293298
"tests/KeyLoad.UnitTests/QueryExecution/Cases/Partition/PartitionQueryPublicMergeTests.cs",
294299
"tests/KeyLoad.UnitTests/QueryExecution/ClientApi/Assertions/PartitionQueryMcpCatalogAssertions.cs",
@@ -307,11 +312,9 @@
307312
"PartitionQueryAuthorizationTests",
308313
"PartitionQueryCancellationTests",
309314
"PartitionQueryContractTests",
310-
"PartitionQueryGrantTests",
311315
"PartitionQueryMcpContractTests",
312316
"PartitionQueryMergeTests",
313317
"PartitionQueryPublicAuthorizationTests",
314-
"PartitionQueryPublicBudgetTests",
315318
"PartitionQueryPublicContractTests",
316319
"PartitionQueryPublicMergeTests"
317320
],
@@ -393,51 +396,6 @@
393396
],
394397
"operationOutcomeAndState": "real plan factory rejects empty/oversized/null leaf input and preserves store position"
395398
},
396-
{
397-
"className": "KeyLoad.UnitTests.QueryExecution.PartitionQueryGrantTests",
398-
"methodName": "ActualReadBytesAndExaminedRecordsAdmitExactlyAndRejectOneLess",
399-
"instanceName": "ActualReadBytesAndExaminedRecordsAdmitExactlyAndRejectOneLess",
400-
"acceptance": [
401-
"AC-PQUERY-004"
402-
],
403-
"requirements": [
404-
"REQ-PQUERY-004"
405-
],
406-
"executedModules": [
407-
"KeyLoad.Query"
408-
],
409-
"operationOutcomeAndState": "measured ZoneTree observer charges exact bytes/records; exact allowances pass and each one-under bound returns BudgetExceeded"
410-
},
411-
{
412-
"className": "KeyLoad.UnitTests.QueryExecution.PartitionQueryGrantTests",
413-
"methodName": "MaxBatchAdmitsTheCompleteMergeAtItsExactBoundAndNoRowsBelowIt",
414-
"instanceName": "MaxBatchAdmitsTheCompleteMergeAtItsExactBoundAndNoRowsBelowIt",
415-
"acceptance": [
416-
"AC-PQUERY-004"
417-
],
418-
"requirements": [
419-
"REQ-PQUERY-004"
420-
],
421-
"executedModules": [
422-
"KeyLoad.Query"
423-
],
424-
"operationOutcomeAndState": "independent serialization/retention bound admits a complete real merge at exact bytes and rejects one byte less"
425-
},
426-
{
427-
"className": "KeyLoad.UnitTests.QueryExecution.PartitionQueryGrantTests",
428-
"methodName": "OneGrantChargesIndexRangeAndDocumentPointReadsTogether",
429-
"instanceName": "OneGrantChargesIndexRangeAndDocumentPointReadsTogether",
430-
"acceptance": [
431-
"AC-PQUERY-004"
432-
],
433-
"requirements": [
434-
"REQ-PQUERY-004"
435-
],
436-
"executedModules": [
437-
"KeyLoad.Query"
438-
],
439-
"operationOutcomeAndState": "execution index range plus point read share the leaf allowance; exact bound passes and one-under examined cap rejects"
440-
},
441399
{
442400
"className": "KeyLoad.UnitTests.QueryExecution.PartitionQueryMergeTests",
443401
"methodName": "RealZoneTreeLeavesMatchIndependentGlobalOrderBeforeProjection",
@@ -530,21 +488,6 @@
530488
],
531489
"operationOutcomeAndState": "Invokes the actual public query path twice and checks exact OwnershipLost and PermissionDenied results; the typed terminal failures are the observed denied operation outcomes and neither returns a page. Root independently reviewed the full body against the accepted AC-CQ-039 operation/outcome criterion."
532490
},
533-
{
534-
"className": "KeyLoad.UnitTests.QueryExecution.PartitionQueryPublicBudgetTests",
535-
"methodName": "OversizedRequestAndPublicPageRetentionFailAtTheirExactBoundaries",
536-
"instanceName": "OversizedRequestAndPublicPageRetentionFailAtTheirExactBoundaries",
537-
"acceptance": [
538-
"AC-PQUERY-001"
539-
],
540-
"requirements": [
541-
"REQ-PQUERY-001"
542-
],
543-
"executedModules": [
544-
"KeyLoad.Query"
545-
],
546-
"operationOutcomeAndState": "oversized request fails before store reads; exact complete public retention succeeds and one byte under fails"
547-
},
548491
{
549492
"className": "KeyLoad.UnitTests.QueryExecution.PartitionQueryPublicContractTests",
550493
"methodName": "GeneratedPublicPageRoundTripsFullReferencesAndPerLeafWitnesses",

‎scripts/Features/CodeQuality/functional-coverage.product-contributors.json‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -179,22 +179,6 @@
179179
],
180180
"operationOutcomeAndState": "A wrong server-owned physical tuple returns OwnershipLost with unchanged position, then the correct owner reads the exact row. A protected sort-field denial returns PermissionDenied with unchanged position; a valid same-reader query returns the visible projection and exact persisted-redaction metadata."
181181
},
182-
{
183-
"suite": "unit",
184-
"className": "KeyLoad.UnitTests.QueryExecution.PartitionQueryPublicBudgetTests",
185-
"methodName": "OversizedRequestAndPublicPageRetentionFailAtTheirExactBoundaries",
186-
"instanceName": "OversizedRequestAndPublicPageRetentionFailAtTheirExactBoundaries",
187-
"requirements": [
188-
"REQ-PQUERY-001"
189-
],
190-
"acceptance": [
191-
"AC-PQUERY-001"
192-
],
193-
"executedModules": [
194-
"KeyLoad.Query"
195-
],
196-
"operationOutcomeAndState": "oversized request fails before store reads; exact complete public retention succeeds and one byte under fails"
197-
},
198182
{
199183
"suite": "unit",
200184
"className": "KeyLoad.UnitTests.QueryExecution.PartitionQueryPublicContractTests",

‎scripts/Features/CodeQuality/functional-coverage.shared.ps1‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ $script:FunctionalCoverage = [ordered]@{
1111
SettingsCopyName = 'functional-coverage.settings.xml'
1212
DeploymentDirectory = 'tests/KeyLoad.UnitTests/bin/Debug/net10.0'
1313
SourceDirectory = 'src/KeyLoad.Query'
14-
SourceCount = 259
15-
ContributorSourceCount = 21
16-
ContributorClassCount = 10
17-
ContributorCaseCount = 25
14+
SourceCount = 266
15+
ContributorSourceCount = 19
16+
ContributorClassCount = 8
17+
ContributorCaseCount = 21
1818
TestNamespace = 'KeyLoad.UnitTests.QueryExecution'
1919
DllName = 'KeyLoad.Query.dll'
2020
PdbName = 'KeyLoad.Query.pdb'
@@ -151,7 +151,7 @@ function Read-FcContract([string] $Path) {
151151
$contract.contributors.testNamePrefix -cne 'PartitionQuery' -or
152152
$contract.contributors.filter -cne '/KeyLoad.UnitTests/*/PartitionQuery*/*' -or
153153
(@($contract.contributors.suiteNames) -join ',') -cne 'unit' -or
154-
(@($contract.contributors.testClasses | Sort-Object) -join ',') -cne 'PartitionQueryAuthorizationTests,PartitionQueryCancellationTests,PartitionQueryContractTests,PartitionQueryGrantTests,PartitionQueryMcpContractTests,PartitionQueryMergeTests,PartitionQueryPublicAuthorizationTests,PartitionQueryPublicBudgetTests,PartitionQueryPublicContractTests,PartitionQueryPublicMergeTests' -or
154+
(@($contract.contributors.testClasses | Sort-Object) -join ',') -cne 'PartitionQueryAuthorizationTests,PartitionQueryCancellationTests,PartitionQueryContractTests,PartitionQueryMcpContractTests,PartitionQueryMergeTests,PartitionQueryPublicAuthorizationTests,PartitionQueryPublicContractTests,PartitionQueryPublicMergeTests' -or
155155
$contract.contributors.exactCases.Count -ne $t.ContributorCaseCount -or
156156
$contract.bounds.originalXmlBytes -ne 33554432 -or $contract.bounds.sources -ne 5000 -or
157157
$contract.bounds.distinctLineLocations -ne 100000 -or

‎tests/KeyLoad.UnitTests/CodeQuality/Assertions/Compilation/ProductionSourceManifestContributorAssertions.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ namespace KeyLoad.UnitTests.CodeQuality.Assertions;
44

55
internal static class ProductionSourceManifestContributorAssertions
66
{
7-
private const int ExpectedUnitRows = 42;
7+
private const int ExpectedUnitRows = 41;
88
private const int ExpectedClusterRows = 9;
99
private const int MaximumIdentityFieldCharacters = 512;
1010
private const int MaximumOperationCharacters = 4096;

‎tests/KeyLoad.UnitTests/CodeQuality/Assertions/Compilation/ProductionSourceManifestExpansionIdentities.cs‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,7 @@ internal static class ProductionSourceManifestExpansionIdentities
44
{
55
internal static readonly string[] Values =
66
[
7-
"unit|KeyLoad.UnitTests.QueryExecution.SqlInnerJoinBudgetTests|AcJoinWorkCountsLeftRecordsAndRightProbesAndLeavesStoreUsableAfterRejection|AcJoinWorkCountsLeftRecordsAndRightProbesAndLeavesStoreUsableAfterRejection",
8-
"unit|KeyLoad.UnitTests.QueryExecution.SqlInnerJoinBudgetTests|AcJoinActualZoneTreeReadBudgetAdmitsTheMeasuredScanAndAllRightProbesAtItsExactBoundary|AcJoinActualZoneTreeReadBudgetAdmitsTheMeasuredScanAndAllRightProbesAtItsExactBoundary",
9-
"unit|KeyLoad.UnitTests.QueryExecution.SqlInnerJoinBudgetTests|AcJoinPageBytesIncludeBothSourcesAndAdmitOnlyTheExactSerializedPageBound|AcJoinPageBytesIncludeBothSourcesAndAdmitOnlyTheExactSerializedPageBound",
10-
"unit|KeyLoad.UnitTests.QueryExecution.SqlInnerJoinBudgetTests|AcJoinResultCountAdmitsTwoActualRowsAndRejectsTheNextRequestedResultWithHealthyFollowUp|AcJoinResultCountAdmitsTwoActualRowsAndRejectsTheNextRequestedResultWithHealthyFollowUp",
117
"unit|KeyLoad.UnitTests.QueryExecution.SqlInnerJoinCancellationTests|AcJoinCancellationAfterRangeProgressSettlesTheOriginalReadAndKeepsTheStoreHealthy|AcJoinCancellationAfterRangeProgressSettlesTheOriginalReadAndKeepsTheStoreHealthy",
12-
"unit|KeyLoad.UnitTests.QueryExecution.SqlInnerJoinCancellationTests|AcJoinDeadlineAfterRangeProgressSettlesTheReadAndKeepsTheStoreHealthy|AcJoinDeadlineAfterRangeProgressSettlesTheReadAndKeepsTheStoreHealthy",
138
"unit|KeyLoad.UnitTests.QueryExecution.SqlInnerJoinExecutionTests|Q2InnerJoinUsesRealZoneTreeRowsAndReturnsOrdinalPairsWithSourceRevisions|Q2InnerJoinUsesRealZoneTreeRowsAndReturnsOrdinalPairsWithSourceRevisions",
149
"unit|KeyLoad.UnitTests.QueryExecution.SqlInnerJoinExecutionTests|NoncurrentDialectOrAstFormatsRejectBeforeReadingAndCurrentJoinStillRuns|NoncurrentDialectOrAstFormatsRejectBeforeReadingAndCurrentJoinStillRuns",
1510
"unit|KeyLoad.UnitTests.QueryExecution.SqlInnerJoinExecutionTests|Q1AliasNamedInnerStaysSupportedAndAnInnerJoinRequiresQ2|Q1AliasNamedInnerStaysSupportedAndAnInnerJoinRequiresQ2",
@@ -23,8 +18,6 @@ internal static class ProductionSourceManifestExpansionIdentities
2318
"cluster|KeyLoad.IntegrationTests.RelationalStorage.RelationalSqlClusterJoinAuthorizationTests|RightResourceAndJoinFieldUseDenialsHaveNoEffectsAndHealthyCallersStillRead|RightResourceAndJoinFieldUseDenialsHaveNoEffectsAndHealthyCallersStillRead",
2419
"cluster|KeyLoad.IntegrationTests.RelationalStorage.RelationalSqlClusterJoinCancellationTests|CallerCancellationOnSdkAndOfficialMcpJoinPathsIsFollowedByHealthyReads|CallerCancellationOnSdkAndOfficialMcpJoinPathsIsFollowedByHealthyReads",
2520
"cluster|KeyLoad.IntegrationTests.RelationalStorage.RelationalSqlClusterJoinReadCutTests|ConcurrentAtomicPairChangesNeverExposeAMixedClusterGeneration|ConcurrentAtomicPairChangesNeverExposeAMixedClusterGeneration",
26-
"cluster|KeyLoad.IntegrationTests.RelationalStorage.RelationalSqlClusterJoinBudgetTests|JoinWorkBudgetReturnsSafeErrorsAndPreservesStateBeforeHealthyFollowUp|JoinWorkBudgetReturnsSafeErrorsAndPreservesStateBeforeHealthyFollowUp",
27-
"cluster|KeyLoad.IntegrationTests.RelationalStorage.RelationalSqlClusterJoinBudgetTests|JoinReadByteBudgetReturnsSafeErrorsAndPreservesStateBeforeHealthyFollowUp|JoinReadByteBudgetReturnsSafeErrorsAndPreservesStateBeforeHealthyFollowUp",
2821
"cluster|KeyLoad.IntegrationTests.RelationalStorage.RelationalSqlClusterJoinBudgetTests|JoinedPageByteBudgetReturnsSafeErrorsAndPreservesStateBeforeHealthyFollowUp|JoinedPageByteBudgetReturnsSafeErrorsAndPreservesStateBeforeHealthyFollowUp",
2922
"unit|KeyLoad.UnitTests.QueryExecution.SqlInnerJoinDeclaredProjectionTests|AcceptedSqlAndDeclaredColumnsUseRealRowsWithExactAstParityAndHealthyQ1Followup|AcceptedSqlAndDeclaredColumnsUseRealRowsWithExactAstParityAndHealthyQ1Followup",
3023
"unit|KeyLoad.UnitTests.StorageRecovery.MaintenancePeriodicLifetimeTests|AcStorageMaintenanceJoin002003ActualPeriodicCleanupJoinsBeforeOwnerFilesAndHealthyReopen|AcStorageMaintenanceJoin002003ActualPeriodicCleanupJoinsBeforeOwnerFilesAndHealthyReopen(False)",

0 commit comments

Comments
 (0)