refactoring

Author: KSemenenko

.github/workflows/Features/BenchmarkComparisons/FunctionalHeavyLoadSetup/AGENTS.md

@@ -2,7 +2,7 @@
 
 ## Purpose, entry points and ownership
 
-Prepare the existing KeyLoad functional cluster million-record ingestion gate with its exact-source images and native runner. Follow root and workflow policies. This action runs no workload and produces no measurements. Preserve the original native admission/workload steps and original result upload as top-level Benchmarks job steps for authenticated provider accounting. No database reset or additional measurement matrix.
+Prepare the existing KeyLoad functional cluster million-record ingestion gate with exact-source native server projects and its native test executable. Follow root and workflow policies. This action runs no workload and produces no measurements. Preserve the original native admission/workload steps and original result upload as top-level Benchmarks job steps for authenticated provider accounting. No database reset or additional measurement matrix.
 
 ## Boundaries and protected risks
 

.github/workflows/Features/BenchmarkComparisons/FunctionalHeavyLoadSetup/action.yml

@@ -1,9 +1,5 @@
 name: Functional CLUSTER heavy-load setup
-description: Prepare source-bound images and the existing native functional CLUSTER runner.
-inputs:
-  bundle-artifact-id:
-    description: Same-source immutable Docker image bundle
-    required: true
+description: Build the real native functional cluster tests; Aspire launches server projects and membership storage.
 runs:
   using: composite
   steps:
@@ -14,22 +10,6 @@ runs:
     - name: Check Docker
       shell: bash
       run: docker version
-    - name: Download exact source Docker images
-      uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131
-      with:
-        artifact-ids: ${{ inputs.bundle-artifact-id }}
-        path: ${{ runner.temp }}/keyload-image-bundle
-    - name: Load and verify Docker images
-      id: images
-      shell: bash
-      run: node scripts/Features/BenchmarkComparisons/import-images.mjs --bundle="$RUNNER_TEMP/keyload-image-bundle"
-    - name: Configure exact source KeyLoad image
-      env:
-        KEYLOAD_SERVER_IMAGE: ${{ steps.images.outputs.server-image }}
-      shell: bash
-      run: |
-        test -n "$KEYLOAD_SERVER_IMAGE"
-        printf 'KeyLoad__ContainerImages__Server=%s\nKEYLOAD_IMAGE_RECEIPT=%s\n' "$KEYLOAD_SERVER_IMAGE" "$RUNNER_TEMP/keyload-images/image-receipt.json" >> "$GITHUB_ENV"
     - name: Restore .NET packages
       shell: bash
       run: dotnet restore KeyLoad.slnx

.github/workflows/Features/BenchmarkComparisons/SessionContracts/action.yml

@@ -5,13 +5,13 @@ runs:
   steps:
     - name: Check native KurrentDB discovery settings
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/IsolatedKurrentDiscoverySettingsTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/kurrent-discovery
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/IsolatedKurrentDiscoverySettingsTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/kurrent-discovery
     - name: Check exact OpenSearch vector query contract
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/OpenSearchVectorQueryTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/opensearch-query
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/OpenSearchVectorQueryTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/opensearch-query
     - name: Check exact OpenSearch vector response contract
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/OpenSearchVectorResponseTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/opensearch-response
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/OpenSearchVectorResponseTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/opensearch-response
     - name: Check TimescaleDB Docker image and startup tools
       env:
         KEYLOAD_TIMESERIES_IMAGE_FACTS_DIRECTORY: ${{ runner.temp }}/keyload-timeseries-image-facts
@@ -30,67 +30,67 @@ runs:
         retention-days: 90
     - name: Test database cluster resource models
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/Isolated*Resource*/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/resource-models
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/Isolated*Resource*/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/resource-models
     - name: Test native session shutdown and original failure retention
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/(IsolatedNativeTeardownSuccessTests|IsolatedNativeTeardownFailureTests|IsolatedNativeLogCaptureConcurrentDisposeTests)/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/session-shutdown --KeyLoadTests:ReportTrx=true
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/(IsolatedNativeTeardownSuccessTests|IsolatedNativeTeardownFailureTests|IsolatedNativeLogCaptureConcurrentDisposeTests)/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/session-shutdown --KeyLoadTests:ReportTrx=true
     - name: Test MongoDB readiness configuration
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/MongoReadinessResourceTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/mongo-resource
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/MongoReadinessResourceTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/mongo-resource
     - name: Test MongoDB node identity
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/MongoReadinessIdentityTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/mongo-identity
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/MongoReadinessIdentityTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/mongo-identity
     - name: Test MongoDB startup failure handling
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/MongoReadinessTaskFailureTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/mongo-task-failure
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/MongoReadinessTaskFailureTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/mongo-task-failure
     - name: Test KurrentDB storage failure handling
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/IsolatedKurrentVolumeRegressionFailureTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/kurrent-volume-failure
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/IsolatedKurrentVolumeChecksFailureTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/kurrent-volume-failure
     - name: Test KeyLoad request admission
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/IsolatedKeyLoadAdmissionTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/keyload-admission
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/IsolatedKeyLoadAdmissionTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/keyload-admission
     - name: Test bounded database log buffers
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/ComparisonResourceLogBufferTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/log-buffer
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/ComparisonResourceLogBufferTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/log-buffer
     - name: Test live benchmark progress capture
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/ComparisonProgress*/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/live-progress
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/ComparisonProgress*/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/live-progress
     - name: Test shared native session entry and safe failures
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/(ComparisonHostStartupTests|ComparisonHostCleanupTests|BenchmarkSessionNativeParserTests)/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/live-entry
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/(ComparisonHostStartupTests|ComparisonHostCleanupTests|BenchmarkSessionNativeParserTests)/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/live-entry
     - name: Test shared session live acknowledgement and cancellation counters
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/BenchmarkSessionProgressTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/live-counters
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/BenchmarkSessionProgressTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/live-counters
     - name: Test document resource budgets and current native topology
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/(DocumentResourceBudgetTests|NativeTopologyAdmissionTests)/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/document-admission --KeyLoadTests:ReportTrx=true
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/(DocumentResourceBudgetTests|NativeTopologyAdmissionTests)/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/document-admission --KeyLoadTests:ReportTrx=true
     - name: Test controlled native shared-session operations and cancellation
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/DocumentComparisonNativeTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/document-native --KeyLoadTests:ReportTrx=true
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/DocumentComparisonNativeTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/document-native --KeyLoadTests:ReportTrx=true
     - name: Test KeyLoad replay admission
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/IsolatedKeyLoadReplayAdmissionTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/replay-admission
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/IsolatedKeyLoadReplayAdmissionTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/replay-admission
     - name: Test Redis replica error reporting
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/RedisReplicaDiagnosticTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/redis-diagnostics
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/RedisReplicaDiagnosticTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/redis-diagnostics
     - name: Test MongoDB startup error reporting
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/MongoBootstrapDiagnosticTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/mongo-diagnostics
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/MongoBootstrapDiagnosticTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/mongo-diagnostics
     - name: Test KurrentDB cleanup error reporting
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/KurrentCleanupDiagnosticTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/kurrent-diagnostics
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/KurrentCleanupDiagnosticTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/kurrent-diagnostics
     - name: Test KurrentDB stream ownership
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/KurrentStreamOwnershipTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/kurrent-stream-ownership
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/KurrentStreamOwnershipTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/kurrent-stream-ownership
     - name: Test database replay logs
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/ComparisonReplayDiagnosticLogTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/replay-log
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/ComparisonReplayDiagnosticLogTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/replay-log
     - name: Test database replay log retention
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/ComparisonReplayDiagnosticRetentionTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/replay-retention
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/ComparisonReplayDiagnosticRetentionTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/replay-retention
     - name: Test time-series workload correctness
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/TimeSeriesWorkloadTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/timeseries-workload
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/TimeSeriesWorkloadTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/timeseries-workload
     - name: Check published time-series package version
       shell: bash
-      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/TimeSeriesPackageVersionTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-images/timeseries-package
+      run: node scripts/Features/TestInfrastructure/run-tests.mjs --KeyLoadTests:Suite=comparison '--KeyLoadTests:Filter=/*/*/TimeSeriesPackageVersionTests/*' --KeyLoadTests:ResultsDirectory=TestResults/comparison-runtime/timeseries-package

.github/workflows/Features/BenchmarkComparisons/SessionSetup/AGENTS.md

@@ -2,7 +2,7 @@
 
 ## Purpose, entry points and ownership
 
-Owns setup for one native database/topology session under ADR-142. Follow root and workflow policies. Authenticate the same-run job, import original source-bound native images and the verified common compiled runtime, and preserve original import receipts. Never restore, build, reset a database, run a workload or manufacture results here. Linux GitHub execution only; scoped image registry shutdown belongs to the existing native lifetime.
+Owns setup for one native database/topology session under ADR-142. Follow root and workflow policies. Authenticate the same-run job, import the verified original compiled server/client/AppHost runtime and preserve original import receipts. Never restore, build, publish images, reset a database, run a workload or manufacture results here. Linux GitHub execution only; the native fixture owns selected infrastructure cleanup.
 
 ## Boundaries and protected risks
 

.github/workflows/Features/BenchmarkComparisons/SessionSetup/action.yml

@@ -1,9 +1,6 @@
 name: Native benchmark session setup
-description: Import the common source-bound Docker images and compiled test runtime.
+description: Authenticate this job and import the exact compiled native server, client and Aspire runtime.
 inputs:
-  image-artifact-id:
-    description: Same-run immutable native image bundle
-    required: true
   runtime-artifact-id:
     description: Same-run immutable compiled runner bundle
     required: true
@@ -22,23 +19,6 @@ runs:
     - name: Verify this GitHub session job
       shell: bash
       run: node scripts/Features/BenchmarkComparisons/session-github-job.mjs
-    - name: Download source-bound Docker images
-      uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131
-      with:
-        artifact-ids: ${{ inputs.image-artifact-id }}
-        path: ${{ runner.temp }}/keyload-image-bundle
-    - name: Import and verify Docker images
-      id: images
-      shell: bash
-      run: node scripts/Features/BenchmarkComparisons/import-images.mjs --bundle="$RUNNER_TEMP/keyload-image-bundle"
-    - name: Configure imported Docker images
-      env:
-        KEYLOAD_SERVER_IMAGE: ${{ steps.images.outputs.server-image }}
-        KEYLOAD_RUNNER_IMAGE: ${{ steps.images.outputs.load-generator-image }}
-      shell: bash
-      run: |
-        test -n "$KEYLOAD_SERVER_IMAGE" && test -n "$KEYLOAD_RUNNER_IMAGE"
-        printf 'KeyLoad__ContainerImages__Server=%s\nBenchmarks__ContainerImages__LoadGenerator=%s\nKEYLOAD_IMAGE_RECEIPT=%s\n' "$KEYLOAD_SERVER_IMAGE" "$KEYLOAD_RUNNER_IMAGE" "$RUNNER_TEMP/keyload-images/image-receipt.json" >> "$GITHUB_ENV"
     - name: Download compiled benchmark runtime
       uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131
       with: