From 1e05a4a9a0855547607adbbadaa5b975a06b816b Mon Sep 17 00:00:00 2001
From: matt wilkie <maphew@gmail.com>
Date: Tue, 6 Oct 2026 22:41:42 -0700
Subject: [PATCH 1/2] Retire the divergent test mirror and dead public surface

C6 / Beads mdo-6w5.2 (epic mdo-6w5, PR order 2 of 6; stacked on the C1
branch).

- tests/cli.rs re-implemented temp_output_for as temp_output_for_test and
  had already lost stem sanitization (diverged from production). The four
  call sites now call mdo_cli::temp_output_for directly, so tests compute
  the same per-source private paths production does, sanitization included.
  The mirror is deleted, along with the Hash/Hasher imports it alone needed.
- The one-line derive_output alias had a single caller; main.rs now calls
  the real target, input.with_extension("html"), and lib no longer exposes
  the alias.
- SETUP_SAMPLE_FILE_NAME / SETUP_SAMPLE_MARKDOWN had zero external callers;
  both are now private. (Windows SetupSample? not referenced: mdo-setup and
  mdo-open never touch them.)
- wrapper.rs's own empty_path_dir duplication is intentionally untouched:
  recorded in the issue as having an honest reason.

Gates: fmt --check, clippy -D warnings, cargo test --all-targets
--all-features --locked (90 tests) all green, including the Linux --open
tests that exercise the corrected temp-output path contract.

Beads-Ref: mdo-6w5.2

Agent-Signature: kilo-kilo-auto-efficient on behalf of matt
---
 src/lib.rs   |  8 ++------
 src/main.rs  |  6 +++---
 tests/cli.rs | 33 +++++++++------------------------
 3 files changed, 14 insertions(+), 33 deletions(-)

diff --git a/src/lib.rs b/src/lib.rs
index 6188564..26a262e 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -29,8 +29,8 @@ pub mod windows_setup;
 const SIMPLE_CSS: &str = include_str!("../assets/simple.min.css");
 const APP_DISPLAY_NAME: &str = "mdo";
 const APP_VERSION: &str = env!("CARGO_PKG_VERSION");
-pub const SETUP_SAMPLE_FILE_NAME: &str = "welcome-to-open-as-html-with-mdo.md";
-pub const SETUP_SAMPLE_MARKDOWN: &str = "\
+const SETUP_SAMPLE_FILE_NAME: &str = "welcome-to-open-as-html-with-mdo.md";
+const SETUP_SAMPLE_MARKDOWN: &str = "\
 # Welcome to the world of Open as HTML with mdo
 
 If you are reading this in your browser, mdo rendered Markdown as HTML and
@@ -135,10 +135,6 @@ const THEME_TOGGLE: &str = r#"<style id="mdo-theme-toggle">
 "#;
 // ─── END THEME TOGGLE ──────────────────────────────────────────────────
 
-pub fn derive_output(input: &Path) -> PathBuf {
-    input.with_extension("html")
-}
-
 /// Stable per-source-path location under a private temp/cache dir, e.g.
 /// `%TEMP%\mdo-<uid>\<hash>\<stem>.html`. Re-opening the same source
 /// overwrites the same file rather than accumulating new ones.
diff --git a/src/main.rs b/src/main.rs
index 734dc41..bb60f10 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -38,8 +38,8 @@ use std::time::Duration;
 
 use clap::Parser;
 use mdo_cli::{
-    convert, derive_output, file_manager, launch_browser, open_setup_sample, temp_output_for,
-    ConvertOutcome, ConvertRequest, RenderError, StageTimings,
+    convert, file_manager, launch_browser, open_setup_sample, temp_output_for, ConvertOutcome,
+    ConvertRequest, RenderError, StageTimings,
 };
 use notify::{recommended_watcher, EventKind, RecursiveMode, Watcher};
 
@@ -395,7 +395,7 @@ fn main() -> notify::Result<()> {
                 std::process::exit(1);
             }
         },
-        (None, false) => (derive_output(&input), false),
+        (None, false) => (input.with_extension("html"), false),
     };
 
     // Register the watch BEFORE the initial render so a save that lands
diff --git a/tests/cli.rs b/tests/cli.rs
index adaccd3..028cecf 100644
--- a/tests/cli.rs
+++ b/tests/cli.rs
@@ -3,11 +3,11 @@ use std::path::PathBuf;
 use std::process::Command;
 use std::time::{SystemTime, UNIX_EPOCH};
 
+use mdo_cli::temp_output_for;
+
 #[cfg(unix)]
 use std::time::{Duration, Instant};
 
-#[cfg(target_os = "linux")]
-use std::hash::{Hash, Hasher};
 #[cfg(target_os = "linux")]
 use std::os::unix::fs::{symlink, PermissionsExt};
 
@@ -570,7 +570,7 @@ fn open_output_refuses_precreated_symlink() {
     fs::write(&input, "# Safe\n\nreplacement").expect("failed to write markdown fixture");
     fs::write(&target, "do not overwrite").expect("failed to write symlink target");
 
-    let output_path = temp_output_for_test(&input);
+    let output_path = temp_output_for(&input).expect("failed to compute expected temp output path");
     fs::create_dir_all(
         output_path
             .parent()
@@ -614,24 +614,6 @@ fn open_output_refuses_precreated_symlink() {
     fs::remove_dir_all(dir).expect("failed to clean up temp fixture dir");
 }
 
-#[cfg(target_os = "linux")]
-fn temp_output_for_test(input: &std::path::Path) -> PathBuf {
-    let canonical = fs::canonicalize(input).unwrap_or_else(|_| input.to_path_buf());
-    let mut hasher = std::collections::hash_map::DefaultHasher::new();
-    canonical.hash(&mut hasher);
-    let hash = hasher.finish();
-
-    let stem = input
-        .file_stem()
-        .and_then(|s| s.to_str())
-        .unwrap_or("document");
-
-    std::env::temp_dir()
-        .join(format!("mdo-{}", unsafe { libc::geteuid() }))
-        .join(format!("{hash:016x}"))
-        .join(format!("{stem}.html"))
-}
-
 /// An empty directory suitable for use as `PATH` when a test needs to make
 /// sure no desktop opener (xdg-open, gio, ...) can be found on it.
 #[cfg(target_os = "linux")]
@@ -671,7 +653,8 @@ fn open_launch_failure_exits_nonzero_and_reports_path() {
         "stderr should report the launch failure: {stderr}"
     );
 
-    let rendered_path = temp_output_for_test(&input);
+    let rendered_path =
+        temp_output_for(&input).expect("failed to compute expected temp output path");
     assert!(
         stderr.contains(
             rendered_path
@@ -721,7 +704,8 @@ fn open_success_exits_zero() {
         "mdo --open should exit zero when render and launch both succeed: {output:?}"
     );
 
-    let rendered_path = temp_output_for_test(&input);
+    let rendered_path =
+        temp_output_for(&input).expect("failed to compute expected temp output path");
     assert!(rendered_path.exists());
 
     fs::remove_dir_all(rendered_path.parent().expect("rendered path has a parent"))
@@ -764,7 +748,8 @@ fn open_reports_failure_when_opener_exits_nonzero() {
         "stderr should report the launch failure: {stderr}"
     );
 
-    let rendered_path = temp_output_for_test(&input);
+    let rendered_path =
+        temp_output_for(&input).expect("failed to compute expected temp output path");
     assert!(
         rendered_path.exists(),
         "rendered output should survive an opener failure"

From 8bd30e53622c049eb423880183c696a69cce3b3d Mon Sep 17 00:00:00 2001
From: matt wilkie <maphew@gmail.com>
Date: Wed, 7 Oct 2026 09:38:19 -0700
Subject: [PATCH 2/2] fix: gate temp_output_for import for linux target

The import was only used in #[cfg(target_os = linux)] tests but was unconditional,
causing clippy -D warnings to fail on macOS/Windows with unused_imports.
This is a follow-up to Beads mdo-6w5.2 (C6).

Agent-Signature: kilo-kilo-auto-efficient on behalf of matt
---
 tests/cli.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/cli.rs b/tests/cli.rs
index 028cecf..f426c92 100644
--- a/tests/cli.rs
+++ b/tests/cli.rs
@@ -3,6 +3,7 @@ use std::path::PathBuf;
 use std::process::Command;
 use std::time::{SystemTime, UNIX_EPOCH};
 
+#[cfg(target_os = "linux")]
 use mdo_cli::temp_output_for;
 
 #[cfg(unix)]