Review: the Qt fixtures and README state what mcpp delivers for the runtime contract on each host (clang on the MSVC ABI links the static CRT); the installation stamp comes from a prepare action

Author: Sunrisepeak

.github/scripts/check-deps-and-qt.sh

@@ -17,7 +17,7 @@ fail() { echo "FAIL: $*"; exit 1; }
 is_windows() { case "$(uname -s)" in MINGW*|MSYS*|CYGWIN*) return 0 ;; *) return 1 ;; esac; }
 is_macos() { [ "$(uname -s)" = Darwin ]; }
 
-# The stamp an installation action leaves: the file mcpp writes when a `check`
+# The stamp an installation action leaves: the file mcpp writes when a `prepare`
 # action's command succeeds. Its modification time is the criterion for "the
 # installation did not run again".
 stamp_of() { find target -path "*$1*" -name '*.stamp' | head -1; }

README.md

@@ -995,8 +995,8 @@ On Linux, Qt's official QtCore links glib, zstd and zlib and the shared
 declares their `lib/` directories as runtime search directories; the program
 states `[build] cxx_runtime = "toolchain-coupled"` (mcpp's docs/20), so the
 process has one C++ runtime. The statement is project-wide because mcpp reads a
-`[target.<triple>]` table only when a target is named; under MSVC it keeps
-`/MD`, and on macOS mcpp keeps the default and says so. Modules that load QtGui are not
+`[target.<triple>]` table only when a target is named (mcpp#704). On macOS and
+under clang on the MSVC ABI mcpp reports the contract it delivers instead. Modules that load QtGui are not
 served on Linux: QtGui loads `libdbus-1.so.3`, which the ecosystem does not
 publish, and mcpp's runtime closure check refuses the program. On macOS the
 modules are frameworks under `lib/`: the rule compiles with `-F<root>/lib` and

tests/qt-consumer/mcpp.toml

@@ -34,9 +34,10 @@ plugins = { path = "../..", features = ["rules-qt-xim"], host-module = true }
 # Qt's Linux libraries load the shared libstdc++ (`libstdc++.so.6`), so the
 # program uses the toolchain's shared C++ runtime rather than embedding a second
 # one (mcpp's docs/20). The statement is project-wide because mcpp reads a
-# `[target.<triple>]` table only when a target is named. On Windows it keeps
-# `/MD`, which Qt's MSVC build uses, and stages the toolset's runtime DLLs; on
-# macOS mcpp reports that it keeps the default.
+# `[target.<triple>]` table only when a target is named (mcpp#704). Elsewhere
+# mcpp reports what it delivers instead: on macOS the default, and under clang
+# on the MSVC ABI the static CRT; a PE image resolves its imports per DLL, so
+# Qt's DLLs keep their own CRT.
 cxx_runtime = "toolchain-coupled"
 sources = ["src/*.cpp", "res/*.qrc", "i18n/*.ts"]
 

tests/qt-widgets-consumer/mcpp.toml

@@ -28,9 +28,10 @@ plugins = { path = "../..", features = ["rules-qt-xim"], host-module = true }
 # Qt's Linux libraries load the shared libstdc++ (`libstdc++.so.6`), so the
 # program uses the toolchain's shared C++ runtime rather than embedding a second
 # one (mcpp's docs/20). The statement is project-wide because mcpp reads a
-# `[target.<triple>]` table only when a target is named. On Windows it keeps
-# `/MD`, which Qt's MSVC build uses, and stages the toolset's runtime DLLs; on
-# macOS mcpp reports that it keeps the default.
+# `[target.<triple>]` table only when a target is named (mcpp#704). Elsewhere
+# mcpp reports what it delivers instead: on macOS the default, and under clang
+# on the MSVC ABI the static CRT; a PE image resolves its imports per DLL, so
+# Qt's DLLs keep their own CRT.
 cxx_runtime = "toolchain-coupled"
 sources = ["src/*.cpp", "ui/*.ui"]