Skip to content

Commit 1db3dc1

Browse files
committed
build: a scan pass names no package at its end
Every package scans in the scan pass, and naming each package that finished a step when that pass ended put a package before the one it imports (e2e 842). A package that only scanned is named when the main pass ends, as before.
1 parent 39f7b54 commit 1db3dc1

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

‎src/build/progress.cppm‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1523,7 +1523,10 @@ void Build::pass_end() {
15231523
std::lock_guard lock(r.m);
15241524
auto& b = *impl_;
15251525
read_log(r, b, out);
1526-
if (b.record)
1526+
// A package that only scanned is named when the main pass ends. A
1527+
// scan pass names nobody at its end: every package scans there, and
1528+
// naming them all at once put a package before the one it imports.
1529+
if (b.record && b.kind != PassKind::Scan)
15271530
for (std::size_t i = 0; i < b.packages.size(); ++i)
15281531
if (b.packages[i].finished > 0) announce(r, b, i, out);
15291532
b.inPass = false;

0 commit comments

Comments
 (0)