From 15557a06337b158c730bff6cd1c41c33d1a6e8d5 Mon Sep 17 00:00:00 2001 From: Kyle Sexton <153232337+kyle-sexton@users.noreply.github.com> Date: Sat, 3 Oct 2026 15:04:55 -0400 Subject: [PATCH 1/3] fix: drop references to the removed docs/topics tree #650 removed docs/topics while #656 added two AGENTS.md links into it, and two tests still read its files, so main went red on lychee-offline and selector-contract. State the two review rules inline and delete the tests that only asserted the removed documents' content. Co-Authored-By: Claude Opus 5.5 --- .../scripts/ci-fanout-consolidation.test.cjs | 19 ------------------- .../claude-review-plugin-path.test.cjs | 17 ----------------- AGENTS.md | 6 ++---- 3 files changed, 2 insertions(+), 40 deletions(-) diff --git a/.github/scripts/ci-fanout-consolidation.test.cjs b/.github/scripts/ci-fanout-consolidation.test.cjs index 7615a84..e64424f 100644 --- a/.github/scripts/ci-fanout-consolidation.test.cjs +++ b/.github/scripts/ci-fanout-consolidation.test.cjs @@ -12,14 +12,6 @@ const ciWorkflowPath = path.join( "workflows", "ci.yml", ); -const adrPath = path.join( - repositoryRoot, - "docs", - "topics", - "ci-fanout-consolidation", - "ADR.md", -); - const ciStatusActionPath = path.join( repositoryRoot, ".github", @@ -29,7 +21,6 @@ const ciStatusActionPath = path.join( ); const ciWorkflow = fs.readFileSync(ciWorkflowPath, "utf8"); -const adr = fs.readFileSync(adrPath, "utf8"); const ciStatusAction = fs.readFileSync(ciStatusActionPath, "utf8"); // Strip the `${{ }}` wrapper, an outer `!( )`, and every run of whitespace, so @@ -409,13 +400,3 @@ test("root CI runs this repository's own test suite in a gating lane", () => { // shfmt covers the same tree, so a shell source there cannot skip formatting. assert.match(ciWorkflow, /paths: fixtures\/shell\/good \.github\/scripts/u); }); - -test("ADR records #122 COMPLETED with Shape A done", () => { - assert.match(adr, /Status: \*\*COMPLETED\*\*/u); - assert.match( - adr, - /\| Shape A \(dotfiles single selector\) \| Done \(confirmed on `dotfiles` `main`\) \|/u, - ); - assert.match(adr, /Main-push burst collapse wins/u); - assert.match(adr, /Hygiene lane consolidation/u); -}); diff --git a/.github/scripts/claude-review-plugin-path.test.cjs b/.github/scripts/claude-review-plugin-path.test.cjs index 2bba3fd..9b9b46b 100644 --- a/.github/scripts/claude-review-plugin-path.test.cjs +++ b/.github/scripts/claude-review-plugin-path.test.cjs @@ -55,20 +55,3 @@ for (const { file, defaultCommand } of [ ); }); } - -test("V2 architecture doc exists and names both skills", () => { - const doc = fs.readFileSync( - path.join( - repositoryRoot, - "docs", - "topics", - "claude-review-lanes", - "V2-PLUGIN-ARCHITECTURE.md", - ), - "utf8", - ); - assert.match(doc, /\/review:code-review/); - assert.match(doc, /\/review:security-review/); - assert.match(doc, /Dual-path|dual-path/); - assert.match(doc, /Migration/); -}); diff --git a/AGENTS.md b/AGENTS.md index 7de7d20..e00cdad 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -10,7 +10,5 @@ Each line names a rule CI does not enforce; the linked file states it in full. - Configurable, not forkable: [rule](README.md#contract). - Policy is authored in standards; `fixtures/` configs only exercise contracts: [rule](README.md#policy-ownership-and-action-inputs). -- Local-lane guard wrappers keep parity with the standards component: - [rule](docs/topics/local-lane-guards.md). -- Lanes consolidate as composite actions; `ci-status` stays the single required check: - [rule](docs/topics/ci-fanout-consolidation/ADR.md#decisions-locked). +- Local-lane guard wrappers keep parity with the standards component. +- Lanes consolidate as composite actions; `ci-status` stays the single required check. From 8cdfe5ca4008982b73cdfabfe6f888b0f6a55bae Mon Sep 17 00:00:00 2001 From: Kyle Sexton <153232337+kyle-sexton@users.noreply.github.com> Date: Sat, 3 Oct 2026 15:08:14 -0400 Subject: [PATCH 2/3] docs(agents): say only linked rules have a fuller statement Co-Authored-By: Claude Opus 5.5 --- AGENTS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AGENTS.md b/AGENTS.md index e00cdad..df88d3f 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -1,6 +1,6 @@ ## Code Review Rules -Each line names a rule CI does not enforce; the linked file states it in full. +Each line names a rule CI does not enforce; a linked file states it in full. - Org-wide criteria: [`REVIEW.md`](REVIEW.md), synced from `melodic-software/standards`. - Claude lane security model (`SECURITY MODEL` headers): From 1b6e2872a0fe02e0b6e4fbeb94892f9a197d5f14 Mon Sep 17 00:00:00 2001 From: Kyle Sexton <153232337+kyle-sexton@users.noreply.github.com> Date: Sat, 3 Oct 2026 15:13:32 -0400 Subject: [PATCH 3/3] docs(agents): admit inline-only review rules in the preamble Co-Authored-By: Claude Opus 5.5 --- AGENTS.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/AGENTS.md b/AGENTS.md index df88d3f..6fe02f8 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -1,6 +1,7 @@ ## Code Review Rules -Each line names a rule CI does not enforce; a linked file states it in full. +Each line names a rule CI does not enforce. A line with a link points at the file that states the +rule in full; a line without one states the whole rule itself. - Org-wide criteria: [`REVIEW.md`](REVIEW.md), synced from `melodic-software/standards`. - Claude lane security model (`SECURITY MODEL` headers):