Skip to content

Commit 29b3d7f

Browse files
claudeclaude
committed
test(persistence): gate field.uri + field.inet write-roundtrip in AllTypes corpus
Wave-3 subtypes field.uri (native URI / text column) and field.inet (native IP / Postgres inet column) shipped with per-port codecs but were not in the persistence-conformance op:roundtrip gate. Add uriVal (field.uri), inetVal + inet6Val (field.inet, IPv4 + IPv6) to the AllTypes entity so every port's runtime WRITE codec re-encodes them on INSERT/UPDATE and the read-back is asserted against the wire-normal form. - meta.fitness.json: +uriVal/+inetVal/+inet6Val on AllTypes. - schema.postgres.sql regenerated (bun run gen:schema): uriVal TEXT, inetVal/inet6Val INET. - roundtrip-all-types.yaml + update-delete-all-types.yaml: seed + expect for all three rows / the UPDATE+DELETE scenario (raw-SQL seed updated for the new NOT NULL columns). - registry-conformance README: mark uri/inet covered in the write-roundtrip matrix. inet read-back finding: a HOST address (no CIDR prefix) round-trips WITHOUT a mask via the inet wire text format (node-pg reads the column directly, not ::text); an explicit ::text cast WOULD append /32 (IPv4) or /128 (IPv6). IPv6 returns its canonical compressed form (2001:0db8:..:8a2e:0370:7334 -> 2001:db8::8a2e:370:7334). Verified empirically against Postgres 16. TS persistence roundtrip green against Testcontainers PG (24/24 query scenarios); schema-artifact drift check + migrate-ts suite green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GF9xLEQZaPus5Y6opk398n
1 parent 97e5574 commit 29b3d7f

5 files changed

Lines changed: 50 additions & 2 deletions

File tree

‎fixtures/persistence-conformance/canonical/meta.fitness.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,9 @@
234234
{ "field.currency": { "name": "moneyVal", "@required": true, "@currency": "USD" } },
235235
{ "field.enum": { "name": "enumVal", "@required": true, "@values": ["LOW", "MEDIUM", "HIGH"] } },
236236
{ "field.uuid": { "name": "uuidVal", "@required": true } },
237+
{ "field.uri": { "name": "uriVal", "@required": true } },
238+
{ "field.inet": { "name": "inetVal", "@required": true } },
239+
{ "field.inet": { "name": "inet6Val", "@required": true } },
237240
{ "field.object": { "name": "settings", "@objectRef": "Settings", "@storage": "jsonb" } },
238241
{ "identity.primary": { "name": "id", "@fields": "id", "@generation": "uuid" } }
239242
]

‎fixtures/persistence-conformance/canonical/schema.postgres.sql‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,9 @@ CREATE TABLE "all_types" (
113113
"moneyVal" BIGINT NOT NULL,
114114
"enumVal" TEXT NOT NULL,
115115
"uuidVal" UUID NOT NULL,
116+
"uriVal" TEXT NOT NULL,
117+
"inetVal" INET NOT NULL,
118+
"inet6Val" INET NOT NULL,
116119
"settings" JSONB,
117120
CONSTRAINT "all_types_pkey" PRIMARY KEY ("id"),
118121
CONSTRAINT "all_types_enumVal_chk" CHECK ("enumVal" IN ('LOW', 'MEDIUM', 'HIGH'))

‎fixtures/persistence-conformance/queries/roundtrip-all-types.yaml‎

Lines changed: 30 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ description: |
1515
1616
string / int / long / double / float / decimal / boolean /
1717
date / time / timestamp / timestamp(tz) / currency / enum / uuid /
18-
object(@objectRef, jsonb storage)
18+
uri / inet (IPv4 + IPv6) / object(@objectRef, jsonb storage)
1919
2020
Tricky wire cases asserted here:
2121
- decimal: exact, canonical (no trailing zeros) → "123.456".
@@ -37,6 +37,15 @@ description: |
3737
renders the identical minimal plain-decimal string (see normalization.md).
3838
- object: a typed @objectRef value-object stored as JSONB → re-serialized
3939
with sorted keys.
40+
- uri: field.uri → TEXT column; round-trips as the verbatim URI string
41+
(no normalization — the port stores/returns it unchanged).
42+
- inet: field.inet → Postgres-native INET column. A HOST address (no CIDR
43+
prefix) round-trips WITHOUT a mask: Postgres's wire text format for inet
44+
omits the /32 (IPv4) or /128 (IPv6) when no prefix was supplied on insert,
45+
so the read-back equals the bare address. (NOTE: an explicit `::text` cast
46+
WOULD append /32 — ports must read the inet column directly, not cast to
47+
text. IPv6 also round-trips in its canonical compressed form, e.g.
48+
`2001:db8::1`.)
4049
4150
queries:
4251
- name: write-all-subtypes-then-read-back
@@ -59,6 +68,9 @@ queries:
5968
moneyVal: 199900
6069
enumVal: "MEDIUM"
6170
uuidVal: "AAAAAAAA-AAAA-4AAA-8AAA-AAAAAAAAAAAA"
71+
uriVal: "https://example.com/a/b?q=1"
72+
inetVal: "192.168.1.1"
73+
inet6Val: "2001:db8::1"
6274
settings: { theme: "dark", notify: true, retries: 3 }
6375
expect:
6476
sVal: "hello"
@@ -75,6 +87,9 @@ queries:
7587
moneyVal: "199900"
7688
enumVal: "MEDIUM"
7789
uuidVal: "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa"
90+
uriVal: "https://example.com/a/b?q=1"
91+
inetVal: "192.168.1.1"
92+
inet6Val: "2001:db8::1"
7893
settings: { notify: true, retries: 3, theme: "dark" }
7994

8095
- name: write-whole-second-temporal-then-read-back
@@ -95,6 +110,9 @@ queries:
95110
moneyVal: 0
96111
enumVal: "LOW"
97112
uuidVal: "11111111-1111-4111-8111-111111111111"
113+
uriVal: "urn:isbn:0451450523"
114+
inetVal: "10.0.0.5"
115+
inet6Val: "fe80::1"
98116
settings: { theme: "light", notify: false, retries: 0 }
99117
expect:
100118
sVal: "second row"
@@ -111,6 +129,9 @@ queries:
111129
moneyVal: "0"
112130
enumVal: "LOW"
113131
uuidVal: "11111111-1111-4111-8111-111111111111"
132+
uriVal: "urn:isbn:0451450523"
133+
inetVal: "10.0.0.5"
134+
inet6Val: "fe80::1"
114135
settings: { notify: false, retries: 0, theme: "light" }
115136

116137
- name: write-full-int64-then-read-back
@@ -143,6 +164,11 @@ queries:
143164
moneyVal: "9223372036854775807"
144165
enumVal: "HIGH"
145166
uuidVal: "ffffffff-ffff-4fff-bfff-ffffffffffff"
167+
uriVal: "https://example.org/path#frag"
168+
inetVal: "255.255.255.255"
169+
# Authored in the long (uncompressed) form; Postgres returns the canonical
170+
# compressed form, so the expected read-back is `2001:db8::8a2e:370:7334`.
171+
inet6Val: "2001:0db8:0000:0000:0000:8a2e:0370:7334"
146172
settings: { theme: "dark", notify: true, retries: 9 }
147173
expect:
148174
sVal: "int64 row"
@@ -159,4 +185,7 @@ queries:
159185
moneyVal: "9223372036854775807"
160186
enumVal: "HIGH"
161187
uuidVal: "ffffffff-ffff-4fff-bfff-ffffffffffff"
188+
uriVal: "https://example.org/path#frag"
189+
inetVal: "255.255.255.255"
190+
inet6Val: "2001:db8::8a2e:370:7334"
162191
settings: { notify: true, retries: 9, theme: "dark" }

‎fixtures/persistence-conformance/queries/update-delete-all-types.yaml‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,14 @@ description: |
4141
seed-data: |
4242
INSERT INTO "all_types" (
4343
"id", "sVal", "iVal", "lVal", "dVal", "fVal", "decVal", "bVal",
44-
"dateVal", "timeVal", "tsVal", "tsTzVal", "moneyVal", "enumVal", "uuidVal", "settings"
44+
"dateVal", "timeVal", "tsVal", "tsTzVal", "moneyVal", "enumVal", "uuidVal",
45+
"uriVal", "inetVal", "inet6Val", "settings"
4546
) VALUES (
4647
'22222222-2222-4222-8222-222222222222',
4748
'before', 1, 1, 0.5, 0.5, 1.000000, true,
4849
'2020-01-01', '00:00:00', '2020-01-01T00:00:00', '2020-01-01T00:00:00Z',
4950
100, 'LOW', '11111111-1111-4111-8111-111111111111',
51+
'urn:example:before', '10.0.0.1', 'fe80::abcd',
5052
'{"theme":"light","notify":false,"retries":0}'
5153
);
5254
@@ -74,6 +76,9 @@ queries:
7476
moneyVal: 250000
7577
enumVal: "HIGH"
7678
uuidVal: "AAAAAAAA-AAAA-4AAA-8AAA-AAAAAAAAAAAA"
79+
uriVal: "https://example.com/after?x=1"
80+
inetVal: "192.168.10.20"
81+
inet6Val: "2001:db8::dead:beef"
7782
settings: { theme: "dark", notify: true, retries: 7 }
7883
expect:
7984
id: "22222222-2222-4222-8222-222222222222"
@@ -91,6 +96,9 @@ queries:
9196
moneyVal: "250000"
9297
enumVal: "HIGH"
9398
uuidVal: "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa"
99+
uriVal: "https://example.com/after?x=1"
100+
inetVal: "192.168.10.20"
101+
inet6Val: "2001:db8::dead:beef"
94102
settings: { notify: true, retries: 7, theme: "dark" }
95103

96104
- name: read-back-after-update
@@ -114,6 +122,9 @@ queries:
114122
moneyVal: "250000"
115123
enumVal: "HIGH"
116124
uuidVal: "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa"
125+
uriVal: "https://example.com/after?x=1"
126+
inetVal: "192.168.10.20"
127+
inet6Val: "2001:db8::dead:beef"
117128
settings: { notify: true, retries: 7, theme: "dark" }
118129

119130
- name: delete-by-pk

‎fixtures/registry-conformance/README.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,8 @@ added without a write-round-trip is visible:
512512
| currency | ✅ | ✅ | ✅ |
513513
| enum | ✅ | ✅ | ✅ |
514514
| uuid | ✅ | ✅ | ✅ |
515+
| uri | ✅ | ✅ | ✅ |
516+
| inet | ✅ | ✅ | ✅ |
515517
| object | ✅ | ✅ | ✅ |
516518

517519
- **persistence write-round-trip** = the `op: roundtrip` scenario type in

0 commit comments

Comments
 (0)