fix(metadata): UriSource.inferFormat strips URI args before extension check

URIs like `model:file:foo.yaml;sourceDir=/x` failed format detection
because endsWith(".yaml") was false when the args followed the
extension. Loader then attempted to parse YAML as JSON and threw a
malformed-JSON error. Downstream adopters had to construct full
URIs by hand as a workaround.

Now strips at the first `;` before checking the suffix.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: dmealing

server/java/metadata/src/main/java/com/metaobjects/loader/UriSource.java

@@ -45,17 +45,33 @@ public UriSource(URI uri) {
      * {@code .yaml} / {@code .yml} → {@link MetaDataFormat#YAML} (sigil-free authoring
      * front-end, ADR-0006); everything else falls back to {@link MetaDataFormat#JSON}
      * (the canonical interchange format).
+     *
+     * <p>URI args (anything after the first {@code ;}) are stripped before the
+     * extension check — model URIs frequently carry args such as
+     * {@code ;sourceDir=/abs/path} appended after the extension, which would
+     * otherwise defeat {@code endsWith} matching and force JSON parsing of
+     * YAML content.</p>
      */
     private static MetaDataFormat inferFormat(String uriString) {
         if (uriString != null) {
-            String lower = uriString.toLowerCase();
+            String lower = stripUriArgs(uriString).toLowerCase();
             if (lower.endsWith(".yaml") || lower.endsWith(".yml")) {
                 return MetaDataFormat.YAML;
             }
         }
         return MetaDataFormat.JSON;
     }
 
+    /**
+     * Returns the portion of a URI string preceding the first {@code ;}, or the
+     * full string if no args are present. Used by {@link #inferFormat(String)}
+     * so that suffix-based extension matching is not defeated by trailing args.
+     */
+    private static String stripUriArgs(String uri) {
+        int semi = uri.indexOf(';');
+        return semi >= 0 ? uri.substring(0, semi) : uri;
+    }
+
     @Override
     public String getId() {
         return id;

server/java/metadata/src/test/java/com/metaobjects/loader/UriSourceTest.java

@@ -48,6 +48,29 @@ public class UriSourceTest {
         }
     }
 
+    @Test public void inferFormatStripsUriArgsBeforeExtensionCheck() {
+        // model:file:<path>;sourceDir=<dir> is the shape MetaDataLoader.processSources
+        // constructs when expanding a bare <source> path. The ;sourceDir=... suffix
+        // must not defeat extension-based format inference.
+        URI uri = URI.create("model:file:common/meta.base-entity.yaml;sourceDir=/tmp/foo");
+        UriSource src = new UriSource(uri);
+        assertEquals(MetaDataSource.MetaDataFormat.YAML, src.getFormat());
+    }
+
+    @Test public void inferFormatStripsUriArgsForYmlExtension() {
+        URI uri = URI.create("model:file:common/meta.thing.yml;sourceDir=/tmp/foo");
+        UriSource src = new UriSource(uri);
+        assertEquals(MetaDataSource.MetaDataFormat.YAML, src.getFormat());
+    }
+
+    @Test public void inferFormatJsonWithUriArgs() {
+        // JSON is the fallback, but verify args-after-extension still classify
+        // correctly (not silently flipping behaviour).
+        URI uri = URI.create("model:file:common/meta.base.json;sourceDir=/tmp/foo");
+        UriSource src = new UriSource(uri);
+        assertEquals(MetaDataSource.MetaDataFormat.JSON, src.getFormat());
+    }
+
     @Test public void readsViaModelFileUri() throws Exception {
         // model:file:<path> URIs route through URIHelper — verify the content
         // resolution path used by fromUris() / fromResources() works end-to-end.