no-mistakes(review): test(fr044-plan3): tighten text-only report test comments and assertions

Author: dmealing

server/java/codegen-spring/src/test/java/com/metaobjects/generator/spring/SpringReportRestSurfaceTest.java

@@ -233,22 +233,17 @@ public void theAllowlistIsEveryDerivedFieldWithItsSubtypeBand() throws Exception
 
     @Test
     public void theControllerServesTheListAndRefusesOnlyTheCollectionPost() throws Exception {
+        // The generated-controller api-contract corpus proves the HTTP behavior (GET list,
+        // POST 405, no /{id}); this pins the source-level shape that produces it.
         String src = Files.readString(generateAll("controller", withModel()).resolve("acme/shop/StoreTotalsController.java"));
         assertTrue("the segment is the report name, snake_cased and pluralized",
             src.contains("@RequestMapping(\"/api/store_totals\")"));
         assertEquals("one GET", 1, occurrences(src, "@GetMapping"));
         assertEquals("one POST", 1, occurrences(src, "@PostMapping"));
         assertFalse("no item route of any verb", src.contains("/{id}"));
-        assertFalse(src.contains("@PathVariable"));
-        assertFalse(src.contains("RequestMethod"));
-        assertFalse(src.contains("findById"));
-        assertTrue(src.contains("Map.of(\"error\", \"method_not_allowed\""));
-        assertTrue("the 405 says what it refused",
-            src.contains("verb + \" is not supported on a report (read-only).\""));
         assertFalse("nothing calls a report a projection", src.contains("projection"));
         assertTrue("every derived field is sortable",
             src.contains("SORT_ALLOWLIST = Set.of(\"purchases\", \"buyers\", \"revenue\");"));
-        assertTrue(src.contains("StoreTotalsFilterAllowlist.FIELDS"));
     }
 
     // === the refusal carried over from Plan 2 ================================

server/python/tests/codegen/test_report_router.py

@@ -163,6 +163,8 @@ def test_report_router_has_the_collection_routes_and_no_item_route() -> None:
 
 
 def test_report_allowlist_names_the_report_s_own_derived_fields() -> None:
+    # Pins the generated allowlist field set; the booted api-contract report corpus drives
+    # filters through it but does not itself assert which fields are in the allowlist.
     root = _load()
     model = report_read_model(_obj(root, "InvoiceStatusTotals"), root)
     src = render_filter_allowlist(model)

server/typescript/packages/codegen-ts/test/projection/queries-file.test.ts

@@ -217,8 +217,8 @@ describe("renderQueriesFile — a served report and a keyless projection (FR-044
   });
 
   test("a projection with an `id` column and no declared identity keeps its by-id query", async () => {
-    // The id-by-convention shape: `getPkInfo` falls back to `id`, the column exists, and
-    // the query compiles and works. It is not keyless, and its output does not move.
+    // The id-by-convention shape: `getPkInfo` falls back to `id`, the column exists.
+    // It is not keyless, so the generated by-id query text does not move.
     const { projection, ctx } = await loadProjectionFixture();
     expect(projection.primaryIdentity()).toBeUndefined();
     const out = renderQueriesFile(projection, ctx);

server/typescript/packages/codegen-ts/test/projection/routes-file.test.ts

@@ -395,6 +395,8 @@ async function loadKeyedProjectionFixture() {
 
 describe("renderRoutesFile — a served report (FR-044 Plan 3)", () => {
   test("a served report mounts a keyless read-only surface", async () => {
+    // Pins the generated call shape (mount function, options, comment text) that the
+    // booted-server api-contract report corpus exercises at runtime but does not itself pin.
     const root = await loadReportingModel();
     const model = reportReadModel(declared(root, "StoreTotals"), root);
     for (const out of [