Skip to content

Commit e89521d

Browse files
dmealingclaude
andcommitted
chore: register codegen-kotlin-exposed1x-check as a reactor-excluded pom
Review fix (MAJOR #3) for issue #390. The new module is excluded from the default reactor (like integration-tests / integration-tests-kotlin), so `mvn versions:set` during a release silently skips it — same latent drift check-pom-versions.sh already guards the other two against. - scripts/check-pom-versions.sh: added server/java/codegen-kotlin-exposed1x-check/pom.xml to EXCLUDED_POMS; updated the header comment ("two" -> "three", and noted this one is excluded for a different reason — a newer Kotlin compiler than the reactor's, not docker). - docs/RELEASING.md step 1: "the two reactor-EXCLUDED integration-test modules" -> "the three reactor-EXCLUDED modules", naming the new one and its different exclusion reason. The tree-wide grep bump already covers it (it globs server/java), so no procedural change — only the count/list. Verified: `scripts/check-pom-versions.sh` passes — "✓ 3 parent + 1 property pom(s) match reactor 8.0.11". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M1mRRB1K2WdYy82kntMQdx
1 parent 0454402 commit e89521d

2 files changed

Lines changed: 17 additions & 10 deletions

File tree

‎docs/RELEASING.md‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -764,9 +764,11 @@ versioned on its own major line — npm major + 7, so `7.x` while npm was `0.x`
764764
765765
## Procedure
766766
767-
1. **Bump** the version in **all** poms — parent + reactor modules **and the two
768-
reactor-EXCLUDED integration-test modules** (`server/java/integration-tests/pom.xml`,
769-
`server/java/integration-tests-kotlin/pom.xml`). Use the tree-wide `grep`, NOT
767+
1. **Bump** the version in **all** poms — parent + reactor modules **and the three
768+
reactor-EXCLUDED modules** (`server/java/integration-tests/pom.xml`,
769+
`server/java/integration-tests-kotlin/pom.xml`, and — issue #390, excluded for a
770+
different reason (a newer Kotlin compiler than the reactor's, not docker) —
771+
`server/java/codegen-kotlin-exposed1x-check/pom.xml`). Use the tree-wide `grep`, NOT
770772
`mvn versions:set`: `versions:set` only walks the reactor and silently leaves the
771773
excluded modules behind, so their `<parent><version>` lags and the next tag fails
772774
`release-gate (java|kotlin)` with "Non-resolvable parent POM".

‎scripts/check-pom-versions.sh‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,18 @@
22
#
33
# Guard: every reactor-EXCLUDED pom must carry the SAME MetaObjects version as the
44
# reactor root (server/java/pom.xml) — whether it names it as a <parent><version>
5-
# (the integration-test modules) or as a <metaobjects.version> property (a project
6-
# that merely CONSUMES the published artifacts, like the website showcase).
5+
# (the three reactor-excluded Java/Kotlin modules below) or as a
6+
# <metaobjects.version> property (a project that merely CONSUMES the published
7+
# artifacts, like the website showcase).
78
#
8-
# Why this exists: integration-tests + integration-tests-kotlin are intentionally
9-
# NOT listed in the parent reactor's <modules> (they need docker; `mvn test` stays
10-
# docker-free — see scripts/integration-test.sh). Because they are outside the
11-
# reactor, `mvn versions:set` during a release bumps every reactor module but
12-
# SILENTLY SKIPS these two. Their <parent><version> then lags (e.g. reactor at
9+
# Why this exists: integration-tests, integration-tests-kotlin, and (issue #390)
10+
# codegen-kotlin-exposed1x-check are intentionally NOT listed in the parent
11+
# reactor's <modules> (they need docker, or in the third's case a newer Kotlin
12+
# compiler than the reactor's — `mvn test` stays docker-free and codegen-kotlin
13+
# stays on Kotlin 2.0.21; see scripts/integration-test.sh and that module's pom).
14+
# Because they are outside the reactor, `mvn versions:set` during a release bumps
15+
# every reactor module but SILENTLY SKIPS these three. Their <parent><version> then
16+
# lags (e.g. reactor at
1317
# 7.5.1-SNAPSHOT, these stuck at 7.4.4-SNAPSHOT), so `../pom.xml` no longer matches
1418
# the declared parent → Maven rejects relativePath, falls back to repos, the
1519
# SNAPSHOT isn't there, and `release-gate (java|kotlin)` fails with
@@ -34,6 +38,7 @@ fi
3438
EXCLUDED_POMS=(
3539
"server/java/integration-tests/pom.xml"
3640
"server/java/integration-tests-kotlin/pom.xml"
41+
"server/java/codegen-kotlin-exposed1x-check/pom.xml"
3742
)
3843

3944
# Poms with NO <parent> that consume the published artifacts through a

0 commit comments

Comments
 (0)