Commit 324200f
committed
lib: document remaining ProxyHandler trap parameters
Several ProxyHandler traps document `target` and then stop, leaving the rest of
their parameters with no description in hover and signature help: `apply` is
missing `thisArg` and `argArray`, `construct` skips `argArray`, `defineProperty`
is missing `property` and `attributes`, and `set` skips `newValue`.
`setPrototypeOf` has the same symptom for a different reason: it documents
`@param newPrototype` while the parameter is named `v`, so the tag matches nothing
and the description is dropped. Rename the parameter to `newPrototype` to match
both the existing tag and the sibling `set` trap, which already spells its value
parameter `newValue` rather than the spec's `V`.1 parent b465fdb commit 324200f
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| 13 | + | |
11 | 14 | | |
12 | 15 | | |
13 | 16 | | |
14 | 17 | | |
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
| 21 | + | |
| 22 | + | |
18 | 23 | | |
19 | 24 | | |
20 | 25 | | |
| |||
77 | 82 | | |
78 | 83 | | |
79 | 84 | | |
| 85 | + | |
80 | 86 | | |
81 | 87 | | |
82 | 88 | | |
| |||
87 | 93 | | |
88 | 94 | | |
89 | 95 | | |
90 | | - | |
| 96 | + | |
91 | 97 | | |
92 | 98 | | |
93 | 99 | | |
| |||
0 commit comments