From ac328793c8ecd16e9a7e42896109a47911396fe9 Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
 <41898282+github-actions[bot]@users.noreply.github.com>
Date: Fri, 7 Aug 2026 22:36:33 +0000
Subject: [PATCH] Clarify completion marker feedback helpers

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 agent/harness/loop/evaluators.go | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/agent/harness/loop/evaluators.go b/agent/harness/loop/evaluators.go
index 254a3e8c..b444d17c 100644
--- a/agent/harness/loop/evaluators.go
+++ b/agent/harness/loop/evaluators.go
@@ -38,10 +38,9 @@ func NewCompletionMarkerEvaluator(config CompletionMarkerConfig) *CompletionMark
 	if config.FeedbackMessageTemplate != "" {
 		template = config.FeedbackMessageTemplate
 	}
-	template = strings.ReplaceAll(template, completionMarkerPlaceholder, marker)
 	return &CompletionMarkerEvaluator{
 		completionMarker:        marker,
-		feedbackMessageTemplate: template,
+		feedbackMessageTemplate: prepareCompletionMarkerFeedbackTemplate(template, marker),
 	}
 }
 
@@ -57,6 +56,13 @@ func (e *CompletionMarkerEvaluator) Evaluate(_ context.Context, loop *Context) (
 	if strings.Contains(responseText, e.completionMarker) {
 		return Stop(), nil
 	}
-	feedback := strings.ReplaceAll(e.feedbackMessageTemplate, lastResponsePlaceholder, responseText)
-	return Continue(feedback), nil
+	return Continue(formatCompletionMarkerFeedback(e.feedbackMessageTemplate, responseText)), nil
+}
+
+func prepareCompletionMarkerFeedbackTemplate(template, marker string) string {
+	return strings.ReplaceAll(template, completionMarkerPlaceholder, marker)
+}
+
+func formatCompletionMarkerFeedback(template, responseText string) string {
+	return strings.ReplaceAll(template, lastResponsePlaceholder, responseText)
 }