diff --git a/packages/trace-viewer/src/ui/actionList.css b/packages/trace-viewer/src/ui/actionList.css index 7161559c62af6..b54ec7fd0d331 100644 --- a/packages/trace-viewer/src/ui/actionList.css +++ b/packages/trace-viewer/src/ui/actionList.css @@ -49,10 +49,20 @@ color: var(--vscode-foreground); } -.action-location > span { +.action-location > button { margin: 0 4px; cursor: pointer; text-decoration: underline; + background: none; + border: none; + padding: 0; + color: inherit; + font: inherit; +} + +.action-location > button:focus-visible { + outline: 1px solid var(--vscode-focusBorder); + outline-offset: -1px; } .action-duration { diff --git a/packages/trace-viewer/src/ui/errorsTab.tsx b/packages/trace-viewer/src/ui/errorsTab.tsx index 36d65c4b7cc97..a10e0af5d9865 100644 --- a/packages/trace-viewer/src/ui/errorsTab.tsx +++ b/packages/trace-viewer/src/ui/errorsTab.tsx @@ -73,7 +73,7 @@ function ErrorView({ message, error, sdkLanguage, revealInSource }: { message: s }}> {error.action && renderAction(error.action, { sdkLanguage })} {location &&
- @ revealInSource(error)}>{location} + @
} diff --git a/packages/trace-viewer/src/ui/networkFilters.tsx b/packages/trace-viewer/src/ui/networkFilters.tsx index dedb250dae895..a08f9a99cf815 100644 --- a/packages/trace-viewer/src/ui/networkFilters.tsx +++ b/packages/trace-viewer/src/ui/networkFilters.tsx @@ -35,6 +35,7 @@ export const NetworkFilters = ({ filterState, onFilterStateChange }: { onFilterStateChange({ ...filterState, searchValue: e.target.value })} diff --git a/packages/trace-viewer/src/ui/uiModeFiltersView.tsx b/packages/trace-viewer/src/ui/uiModeFiltersView.tsx index 0579a741e1d89..722f1e758ba1b 100644 --- a/packages/trace-viewer/src/ui/uiModeFiltersView.tsx +++ b/packages/trace-viewer/src/ui/uiModeFiltersView.tsx @@ -46,7 +46,7 @@ export const FiltersView: React.FC<{ { setFilterText(e.target.value); }} diff --git a/tests/library/trace-viewer.spec.ts b/tests/library/trace-viewer.spec.ts index a88c9cb3b4b89..7852c68482f68 100644 --- a/tests/library/trace-viewer.spec.ts +++ b/tests/library/trace-viewer.spec.ts @@ -649,6 +649,8 @@ test('should filter network requests by url', async ({ page, runAndTrace, server await traceViewer.selectAction('Navigate'); await traceViewer.showNetworkTab(); + await expect(traceViewer.page.getByRole('searchbox', { name: 'Filter network' })).toBeVisible(); + await traceViewer.page.getByPlaceholder('Filter network').fill('script.'); await expect(traceViewer.networkRequests).toHaveCount(1); await expect(traceViewer.networkRequests.getByText('script.js')).toBeVisible();