Skip to content

[BUG] Issue with failing tests in PR pipeline #937

@catalina-gav

Description

@catalina-gav

🐛 What happened?

Two tests are failing intermittently in the PR pipeline Run Tests job.

TestAcc_WorkspaceNetworkCommunicationPolicy_CRUD
Fails with:

Image

Root cause: The test sets the inbound communication policy to deny, which then blocks subsequent read operations on the workspace resource.

TestUnit_TenantSettingsDataSource
Fails with:

Image Possible root cause: The data source test expects all entities to have enabled_security_groups populated. However, TestUnit_TenantSettingsResource_CRUD inserts an entity via NewRandomTenantSettingsWithoutProperties() into the shared fakeTenantSettingsStore — this entity has no security groups or properties. Since tests run in parallel and Go map iteration order is non-deterministic, the data source test may read this incomplete entity at values.0, causing the attribute checks to fail.

While reviewing the acceptance tests, I noticed that tests modifying Object-level Access Policies on a shared workspace can fail intermittently when multiple CI matrix jobs run in parallel against the same FABRIC_TESTACC_WELLKNOWN workspace, causing them to overwrite each other's state. Proposed solution: Modify the following tests to use a newly created workspace instead of the workspaceOAP: TestAcc_WorkspaceSetOutboundCloudConnectionRules_CRUD TestAcc_WorkspaceSetOutboundGatewayRules_CRUD TestAcc_WorkspaceSetGitOutboundPolicy_CRUD ### 🔬 How to reproduce?

Trigger the Run Tests job on any PR. Failures are intermittent due to parallel test execution and non-deterministic map iteration.

🏗️ Code Sample / Log

No response

📷 Screenshots

No response

📈 Expected behavior

No response

🌌 Environment (Provider Version)

1.9.1

🌌 Environment (Terraform Version)

v1.13.3

🌌 Environment (OS)

Linux

📎 Additional context

No response

🔰 Code of Conduct

  • I agree to follow this project's Code of Conduct.

Metadata

Metadata

Labels

bugSomething isn't working

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions