From 4fe9d258d53a10215181e7ffefc89e2f9cb5850c Mon Sep 17 00:00:00 2001 From: Tobias Svane Mikkelsen Date: Tue, 28 Jul 2026 14:59:18 +0200 Subject: [PATCH] fix: drop --accept-routes from tailscale args, v4 passes it by default tailscale/github-action v4 hardcodes --accept-routes in tailscale up (src/main.ts), so repeating it in args fails every attempt with "invalid boolean flag accept-routes: flag provided multiple times". continue-on-error masked this and Sonar steps were silently skipped. Co-Authored-By: Claude Fable 5 --- .github/workflows/pull-request-kotlin.yml | 3 ++- .github/workflows/sonar-cloud.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pull-request-kotlin.yml b/.github/workflows/pull-request-kotlin.yml index 42cd0ae..20a1d9e 100644 --- a/.github/workflows/pull-request-kotlin.yml +++ b/.github/workflows/pull-request-kotlin.yml @@ -202,7 +202,8 @@ jobs: with: authkey: ${{ env.TAILSCALE_AUTHKEY }} hostname: "github-${{ github.run_id }}" - args: "--login-server https://headscale.monta.com --accept-routes" + # v4 passes --accept-routes itself; repeating it in args fails `tailscale up` + args: "--login-server https://headscale.monta.com" # Wait for the tailnet path to SonarQube to actually be usable before # scanning. `tailscale up` returns before DERP/route programming has # settled, so the scanner's first call (GET /api/v2/analysis/version) diff --git a/.github/workflows/sonar-cloud.yml b/.github/workflows/sonar-cloud.yml index 5cc32ca..f828870 100644 --- a/.github/workflows/sonar-cloud.yml +++ b/.github/workflows/sonar-cloud.yml @@ -108,7 +108,8 @@ jobs: with: authkey: ${{ env.TAILSCALE_AUTHKEY }} hostname: "github-${{ github.run_id }}" - args: "--login-server https://headscale.monta.com --accept-routes" + # v4 passes --accept-routes itself; repeating it in args fails `tailscale up` + args: "--login-server https://headscale.monta.com" - name: Run tests with coverage env: GHL_USERNAME: ${{ secrets.GHL_USERNAME }}