diff --git a/.github/workflows/codeowners.yml b/.github/workflows/codeowners.yml index d10948c..82d9a74 100644 --- a/.github/workflows/codeowners.yml +++ b/.github/workflows/codeowners.yml @@ -2,7 +2,8 @@ name: 'Code Owners' concurrency: group: codeowners-${{ github.ref }} - cancel-in-progress: true + # queue duplicate runs - cancelled runs read as a failed check (#195) + cancel-in-progress: false on: pull_request: diff --git a/.github/workflows/rerun_codeowners.yml b/.github/workflows/rerun_codeowners.yml index ef913f5..54f591b 100644 --- a/.github/workflows/rerun_codeowners.yml +++ b/.github/workflows/rerun_codeowners.yml @@ -16,7 +16,7 @@ jobs: checks: read steps: - name: 'Rerun Checks' - uses: shqear93/rerun-checks@fd4069ad25c810179f1cb7437f5535fdf4a8b0fa # v3 + uses: shqear93/rerun-checks@fd4069ad25c810179f1cb7437f5535fdf4a8b0fa # v3.1.0 with: github-token: '${{ secrets.GITHUB_TOKEN }}' check-names: 'Run Codeowners Plus' diff --git a/README.md b/README.md index 90857ad..aafe858 100644 --- a/README.md +++ b/README.md @@ -70,7 +70,8 @@ name: 'Code Owners' concurrency: group: codeowners-${{ github.ref }} - cancel-in-progress: true + # queue duplicate runs - cancelled runs read as a failed check (#195) + cancel-in-progress: false on: pull_request: @@ -103,7 +104,7 @@ jobs: The `Codeowners Plus` GitHub Action should be set up as a [required status check](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches#require-status-checks-before-merging) in a GitHub Workflow. -It is recommended to also set up a rerun workflow on `pull_request_review` to rerun the check (see [.github/workflows/rerun_codeowners.yml](.github/workflows/rerun_codeowners.yml) for an example). +It is recommended to also set up a rerun workflow on `pull_request_review` to rerun the check (see [.github/workflows/rerun_codeowners.yml](.github/workflows/rerun_codeowners.yml) for an example). Note that the rerun workflow's `check-names` must exactly match the job `name` in your codeowners workflow (`Run Codeowners Plus` above) — if they differ, reviews will silently stop triggering reruns. **For advanced features to work, such as only re-requesting review when owned files are changed, you must disable this rule in branch protections:** `Dismiss stale pull request approvals when new commits are pushed`