Fix: Remove user memoization#2674
Merged
Merged
Conversation
2bc0e8c to
e5d2576
Compare
artonge
approved these changes
Jun 24, 2026
00eb0dd to
105d42c
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
105d42c to
1673f42
Compare
Contributor
Author
|
Psalm failures looks a bit unrelated... All other pipelines are green |
Collaborator
|
Some were related @Koc : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User memoization in the Activity app causes incorrect activity notifications in edge cases, particularly when activities are generated about files changed by other users. This was observed in the Forms app.
Reproducer:
SyncSubmissionsWithLinkedFileJobto executeRoot cause:
The memoized user state persists across console commands and background jobs, even when the user context changes via:
Solution:
Remove user memoization at the Activity level since it's not needed and causes state leakage between different user contexts.
🤖 AI (if applicable)