fix(proxy): validate request path before forwarding to ExApp

[oleksandr-nc]

Making the algo in AppAPI align with the HaRP repo changes:

nextcloud/HaRP@067c09f

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fa651302-6c8b-4eec-8255-11385f7f55c7

📥 Commits

Reviewing files that changed from the base of the PR and between 878eeb2 and 215346a.

📒 Files selected for processing (1)

• lib/Controller/ExAppProxyController.php

---

📝 Walkthrough

Walkthrough

This pull request adds a security validation layer to the ExApp proxy controller. The prepareProxy() method now includes a regex-based check that detects parent-directory traversal sequences (such as ../) in the requested path parameter. When a traversal segment is identified, the method logs a debug message and returns null, which causes the proxy endpoint to respond with a 404 Not Found response instead of processing the request.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix(proxy): validate request path before forwarding to ExApp' directly and specifically describes the main change—adding path validation to reject parent-directory traversal segments in proxy requests.
Description check	✅ Passed	The description references alignment with HaRP repository changes and provides a commit link, which is related to the path validation security fix in the proxy controller, though it could be more detailed.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[oleksandr-nc]

/backport to stable33

[oleksandr-nc]

/backport to stable32

[oleksandr-nc]

/backport to stable31

[oleksandr-nc]

/backport to stable30