feat: validate ExApp routes at registration and reject malformed data#885
feat: validate ExApp routes at registration and reject malformed data#885oleksandr-nc wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThis PR refactors ExApp route validation by extracting normalization logic into a dedicated helper class and integrating it into the service layer. The new 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
….xml/--json-info Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
1b83547 to
8d57f2e
Compare
Follow-up to #882, which added defensive read-side parsing for nullable / malformed
bruteforce_protectionandheaders_to_excludecolumns.That PR which added defensive read-side parsing for nullable / malformed
bruteforce_protectionandheaders_to_excludecolumns. That PR kept legacy rows working but left the write side silently coercing any unrecognised value to'[]'- so a developer with a typo in theirinfo.xmlgot an apparently-installed ExApp whose routes didn't behave as written, with no error to point them at the mistake.This PR moves to fail-fast: every route definition from
--info-xml,--json-inforuns through a newExAppRouteHelper::normalizeAndValidate()step insideExAppService::getAppInfo().