build: remove outdated CSS files when building - #129
Merged
Conversation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1 task
moodyjmz
approved these changes
Aug 24, 2026
moodyjmz
left a comment
moodyjmz
left a comment
Contributor
There was a problem hiding this comment.
Reviewed: 3-line vite.config.ts change, verified emptyOutputDirectory.additionalDirectories is a real @nextcloud/vite-config option that doesn't disable the existing js/ emptying and doesn't race with the CSS-entrypoint/license plugins. css/ holds only build output so wholesale deletion is safe. The failing NPM build/node checks are the expected self-announcing 'stale build output' gate (needs /compile after merge, same as #110). Filed #132 for a related pre-commit hook gap (doesn't flag deleted js/css, newly reachable after this change) as a non-blocking follow-up.
Contributor
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com> # Conflicts: # css/main-CxcBSS6q.chunk.css
Contributor
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃 AI (if applicable)