Incoming PHP-FPM changes for httpd ProxyPass and ProxyPassMatch handling.

[bukka]

Apology for opening this nextcloud possible non issue but wanted to double check with you some changes that I'm adding to php-fpm in terms of handling PATH_INFO from ProxyPass and ProxyPassMatch which is quite inconsistent. The issue with those is that they send URL encoded path info and script file name. I applied the PATH_INFO fix in php/php-src#17643 which just got merged and should be part of 8.3.18. It will basically provide the PATH_INFO decode. This should be quite safe but wanted to check with you in case you do some special handling for that. Another one which would decode the whole script path will be probably just for master: php/php-src#17645 . But if you can see any issue with that, I could maybe add some switch for it.

This is mainly created here because there were some issues reported here. This in relation to past bugs #37852 and #40943 create by @mrAceT .

Feel free to close this it if you don't see any potential issues for nextcloud after this gets implemented.

[kesselb]

cc @sorbaugh @juliusknorr

[nickvergessen]

Thanks for the hint @bukka 🙇

[sorbaugh]

The 2 bugs linked seems to be closed and consensus is that this is a PHP bug. Is there anything we need to do?

[bukka]

I'm just asking if you by any chance do some extra decoding of the path info or relay on the script path being encoded. There is basically inconsistency with ProxyPass approach that I plan to change in PHP and just making sure that it won't cause issues to nextcloud where some PHP related problems were reported in past (those were actually happening because we were not decoding some other parts and this time I want to decode more which should make things better but one never knows if apps might somehow rely on the current bugy behaviour).

[sorbaugh]

Will re-check, thank you!

[szaimen]

Hi, is the request answered?