ci(review): improve instructions, comment inline, guardrails

[nickjvandyke]

Tasks

• I read CONTRIBUTING.md
• I ensured my changes pass automated checks
• I reviewed and understand the AI-generated code in my changes (if any)
• I addressed actionable AI review feedback (if any)

Description

Testing

Related Issue(s)

Screenshots/Videos

[nickjvandyke]

/review

[github-actions]

I've reviewed the PR. Here's my analysis:

---

Review

Changes Summary

• PULL_REQUEST_TEMPLATE.md: Removes the "I addressed actionable AI review feedback" checkbox
• opencode-review.yml: Adds OPENCODE_PERMISSION guardrails, improves the review prompt, increases timeout to 5 min

Issues

1. Permission rule order may be a bug (opencode-review.yml:28)

{ "bash": { "*": "deny", "gh*": "allow", "gh pr review*": "deny", "gh pr review --comment*": "allow" } }

The gh pr review* deny rule appears before the gh pr review --comment* allow rule. If opencode's permission matcher uses first-match-wins (instead of most-specific-wins), the broader deny will catch gh pr review --comment ... before the allow rule is ever reached, meaning inline comments won't be posted. Consider reversing the order so the specific allow comes first, or verify the matcher uses most-specific-wins semantics.

2. Prompt references CONTRIBUTING.md link with fork URL (opencode-review.yml:43)

The template links to https://github.com/nickjvandyke/opencode.nvim/blob/main/CONTRIBUTING.md — this should be the canonical org URL (anomalyco/opencode.nvim). Not introduced in this PR but worth fixing.

Suggestions

• Good: The permission guardrail is a smart safety addition. Running the review as OWNER with broad gh access could be dangerous otherwise.
• Good: The prompt improvements — calling out PR health, asking for full-file context, distinguishing inline vs. high-level review comments — will produce better reviews.
• Good: Timeout bump to 5 min is reasonable for a more thorough review pass.

Verdict

Approved with one concern about permission ordering. Fix that before merging if the matcher is first-match-wins.

opencode session  |  github run