fs: fix close listener leak in fs streams

Author: Y1D7NG

lib/internal/fs/streams.js

@@ -152,7 +152,23 @@ function importFd(stream, options) {
     stream[kHandle] = options.fd;
     stream[kFs] = FileHandleOperations(stream[kHandle]);
     stream[kHandle][kRef]();
-    options.fd.on('close', FunctionPrototypeBind(stream.close, stream));
+
+    const onclose = FunctionPrototypeBind(stream.close, stream);
+    options.fd.on('close', onclose);
+    if (options.autoClose === false) {
+      function cleanup() {
+        const handle = stream[kHandle];
+        if (handle === null)
+          return;
+        stream[kHandle] = null;
+        handle.removeListener('close', onclose);
+        handle[kUnref]();
+      }
+      stream.once('end', cleanup);
+      stream.once('finish', cleanup);
+      stream.once('error', cleanup);
+    }
+
     return options.fd.fd;
   }
 

test/parallel/test-fs-promises-file-handle-stream.js

@@ -42,7 +42,27 @@ async function validateRead() {
   );
 }
 
+async function validateReusedCreateReadStream() {
+  const filePath = path.resolve(tmpDir, 'tmp-reused-stream.txt');
+  fs.writeFileSync(filePath, Buffer.alloc(11, 0));
+
+  const fileHandle = await open(filePath, 'r');
+  try {
+    for (let i = 0; i < 11; i++) {
+      await buffer(fileHandle.createReadStream({
+        start: i,
+        end: i,
+        autoClose: false,
+      }));
+      assert.strictEqual(fileHandle.listenerCount('close'), 0);
+    }
+  } finally {
+    await fileHandle.close();
+  }
+}
+
 Promise.all([
   validateWrite(),
   validateRead(),
+  validateReusedCreateReadStream(),
 ]).then(common.mustCall());