Change ModuleWrap::SyntheticModuleEvaluationStepsCallback to return a MaybeLocal<Promise>

Author: caiolima

src/module_wrap.cc

@@ -1442,7 +1442,7 @@ void ModuleWrap::SetInitializeImportMetaObjectCallback(
       HostInitializeImportMetaObjectCallback);
 }
 
-MaybeLocal<Value> ModuleWrap::SyntheticModuleEvaluationStepsCallback(
+MaybeLocal<Promise> ModuleWrap::SyntheticModuleEvaluationStepsCallback(
     Local<Context> context, Local<Module> module) {
   Environment* env = Environment::GetCurrent(context);
   Isolate* isolate = env->isolate();
@@ -1466,16 +1466,16 @@ MaybeLocal<Value> ModuleWrap::SyntheticModuleEvaluationStepsCallback(
     CHECK(!try_catch.Message().IsEmpty());
     CHECK(!try_catch.Exception().IsEmpty());
     try_catch.ReThrow();
-    return MaybeLocal<Value>();
+    return MaybeLocal<Promise>();
   }
 
   Local<Promise::Resolver> resolver;
   if (!Promise::Resolver::New(context).ToLocal(&resolver)) {
-    return MaybeLocal<Value>();
+    return MaybeLocal<Promise>();
   }
 
   if (resolver->Resolve(context, Undefined(isolate)).IsNothing()) {
-    return MaybeLocal<Value>();
+    return MaybeLocal<Promise>();
   }
   return resolver->GetPromise();
 }

src/module_wrap.h

@@ -185,7 +185,7 @@ class ModuleWrap : public BaseObject {
       const v8::FunctionCallbackInfo<v8::Value>& args);
   static void SetInitializeImportMetaObjectCallback(
       const v8::FunctionCallbackInfo<v8::Value>& args);
-  static v8::MaybeLocal<v8::Value> SyntheticModuleEvaluationStepsCallback(
+  static v8::MaybeLocal<v8::Promise> SyntheticModuleEvaluationStepsCallback(
       v8::Local<v8::Context> context, v8::Local<v8::Module> module);
   static void SetSyntheticExport(
       const v8::FunctionCallbackInfo<v8::Value>& args);