deps: V8: cherry-pick a6eaf7574109

Original commit message:

    [logging] Use RecursiveMutex for Logger

    Logger::allows_code_compaction might be called from within a
    CodeCreateEvent where initializing line script line ends might trigger
    a GC. During compaction we check if code compaction is allowed which
    calls back into the above Logger method.

    Bug: 41497149
    Change-Id: Ifd1b740df8600584780341d8214e995832e663b4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5572952
    Reviewed-by: Victor Gomes <victorgomes@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#94140}

Refs: v8/v8@a6eaf75

Author: camillobruni

common.gypi

@@ -38,7 +38,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.56',
+    'v8_embedder_string': '-node.57',
 
     ##### V8 defaults for Node.js #####
 

deps/v8/src/logging/code-events.h

@@ -125,7 +125,7 @@ class Logger {
   Logger& operator=(const Logger&) = delete;
 
   bool AddListener(LogEventListener* listener) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     auto position = std::find(listeners_.begin(), listeners_.end(), listener);
     if (position != listeners_.end()) return false;
     // Add the listener to the end and update the element
@@ -134,23 +134,23 @@ class Logger {
   }
 
   bool RemoveListener(LogEventListener* listener) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     auto position = std::find(listeners_.begin(), listeners_.end(), listener);
     if (position == listeners_.end()) return false;
     listeners_.erase(position);
     return true;
   }
 
   bool is_listening_to_code_events() {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       if (listener->is_listening_to_code_events()) return true;
     }
     return false;
   }
 
   bool allows_code_compaction() {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       if (!listener->allows_code_compaction()) return false;
     }
@@ -159,23 +159,23 @@ class Logger {
 
   void CodeCreateEvent(CodeTag tag, Handle<AbstractCode> code,
                        const char* comment) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->CodeCreateEvent(tag, code, comment);
     }
   }
 
   void CodeCreateEvent(CodeTag tag, Handle<AbstractCode> code,
                        Handle<Name> name) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->CodeCreateEvent(tag, code, name);
     }
   }
 
   void CodeCreateEvent(CodeTag tag, Handle<AbstractCode> code,
                        Handle<SharedFunctionInfo> shared, Handle<Name> name) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->CodeCreateEvent(tag, code, shared, name);
     }
@@ -184,7 +184,7 @@ class Logger {
   void CodeCreateEvent(CodeTag tag, Handle<AbstractCode> code,
                        Handle<SharedFunctionInfo> shared, Handle<Name> source,
                        int line, int column) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->CodeCreateEvent(tag, code, shared, source, line, column);
     }
@@ -194,7 +194,7 @@ class Logger {
   void CodeCreateEvent(CodeTag tag, const wasm::WasmCode* code,
                        wasm::WasmName name, const char* source_url,
                        int code_offset, int script_id) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->CodeCreateEvent(tag, code, name, source_url, code_offset,
                                 script_id);
@@ -203,80 +203,80 @@ class Logger {
 #endif  // V8_ENABLE_WEBASSEMBLY
 
   void CallbackEvent(Handle<Name> name, Address entry_point) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->CallbackEvent(name, entry_point);
     }
   }
 
   void GetterCallbackEvent(Handle<Name> name, Address entry_point) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->GetterCallbackEvent(name, entry_point);
     }
   }
 
   void SetterCallbackEvent(Handle<Name> name, Address entry_point) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->SetterCallbackEvent(name, entry_point);
     }
   }
 
   void RegExpCodeCreateEvent(Handle<AbstractCode> code, Handle<String> source) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->RegExpCodeCreateEvent(code, source);
     }
   }
 
   void CodeMoveEvent(Tagged<InstructionStream> from,
                      Tagged<InstructionStream> to) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->CodeMoveEvent(from, to);
     }
   }
 
   void BytecodeMoveEvent(Tagged<BytecodeArray> from, Tagged<BytecodeArray> to) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->BytecodeMoveEvent(from, to);
     }
   }
 
   void SharedFunctionInfoMoveEvent(Address from, Address to) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->SharedFunctionInfoMoveEvent(from, to);
     }
   }
 
   void NativeContextMoveEvent(Address from, Address to) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->NativeContextMoveEvent(from, to);
     }
   }
 
   void CodeMovingGCEvent() {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->CodeMovingGCEvent();
     }
   }
 
   void CodeDisableOptEvent(Handle<AbstractCode> code,
                            Handle<SharedFunctionInfo> shared) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->CodeDisableOptEvent(code, shared);
     }
   }
 
   void CodeDeoptEvent(Handle<Code> code, DeoptimizeKind kind, Address pc,
                       int fp_to_sp_delta) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->CodeDeoptEvent(code, kind, pc, fp_to_sp_delta);
     }
@@ -285,22 +285,22 @@ class Logger {
   void CodeDependencyChangeEvent(Handle<Code> code,
                                  Handle<SharedFunctionInfo> sfi,
                                  const char* reason) {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->CodeDependencyChangeEvent(code, sfi, reason);
     }
   }
 
   void WeakCodeClearEvent() {
-    base::MutexGuard guard(&mutex_);
+    base::RecursiveMutexGuard guard(&mutex_);
     for (auto listener : listeners_) {
       listener->WeakCodeClearEvent();
     }
   }
 
  private:
   std::vector<LogEventListener*> listeners_;
-  base::Mutex mutex_;
+  base::RecursiveMutex mutex_;
 };
 
 }  // namespace internal