From c461578b5cc01b7e0a320b8847a49f605a70d148 Mon Sep 17 00:00:00 2001 From: Stewart X Addison Date: Thu, 2 Jul 2026 14:26:38 +0100 Subject: [PATCH 1/3] doc: add note on visibility of CI failures to new contributor guide Signed-off-by: Stewart X Addison --- doc/contributing/first-contributions.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/contributing/first-contributions.md b/doc/contributing/first-contributions.md index 0d4bf7f35a6b40..40225f794fe5fd 100644 --- a/doc/contributing/first-contributions.md +++ b/doc/contributing/first-contributions.md @@ -168,6 +168,13 @@ before approving the CI runs. Similar to the review process, be patient and resp the volunteers' time when you are asking for help to trigger the CI runs, this helps build trust to make future contributions smoother. +Since read access to the CI is also restricted, one of the collaborators also will need to let +you know about any failures unless you are a member of one of the platform teams in the Node.js +organisation. If after a day or so from a collaborator triggering a CI your PR shows a failure +in either the `node-test-pull-request` or `node-test-commit-*` checks it's worth adding a +comment to the PR asking what tests are failed, as the collaborator may not realise that you +cannot see the results directly in the CI. + ### Q: The CI runs showed some failures that seem unrelated to my change. What should I do? The Node.js CIs are known to be flaky. Consult the daily reports in From 649c1be74f0d05bdeb7990e246078e69b027f0a2 Mon Sep 17 00:00:00 2001 From: Stewart X Addison Date: Fri, 3 Jul 2026 13:26:14 +0100 Subject: [PATCH 2/3] fixups following review Signed-off-by: Stewart X Addison --- doc/contributing/first-contributions.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/contributing/first-contributions.md b/doc/contributing/first-contributions.md index 40225f794fe5fd..31e07e6d6a8308 100644 --- a/doc/contributing/first-contributions.md +++ b/doc/contributing/first-contributions.md @@ -168,12 +168,12 @@ before approving the CI runs. Similar to the review process, be patient and resp the volunteers' time when you are asking for help to trigger the CI runs, this helps build trust to make future contributions smoother. -Since read access to the CI is also restricted, one of the collaborators also will need to let -you know about any failures unless you are a member of one of the platform teams in the Node.js -organisation. If after a day or so from a collaborator triggering a CI your PR shows a failure -in either the `node-test-pull-request` or `node-test-commit-*` checks it's worth adding a -comment to the PR asking what tests are failed, as the collaborator may not realise that you -cannot see the results directly in the CI. +Since read access to the Jenkins CI is also restricted, one of the collaborators also will need to +let you know about any failures unless you are a member of one of the platform teams in the Node.js +organisation. If after a day or so from a collaborator triggering a Jenkins CI your PR shows a +failure in either the `node-test-pull-request` or `node-test-commit-*` checks it's worth adding a +comment to the PR asking what tests are failed, as the collaborator may not realise that you cannot +see the results directly. ### Q: The CI runs showed some failures that seem unrelated to my change. What should I do? From b0de4e926dddd6927b20f637ef8ef129bb6f8146 Mon Sep 17 00:00:00 2001 From: Stewart X Addison <6487691+sxa@users.noreply.github.com> Date: Sat, 4 Jul 2026 20:06:45 +0100 Subject: [PATCH 3/3] Update doc/contributing/first-contributions.md Co-authored-by: Joyee Cheung --- doc/contributing/first-contributions.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/contributing/first-contributions.md b/doc/contributing/first-contributions.md index 31e07e6d6a8308..8bd96d9a3639fc 100644 --- a/doc/contributing/first-contributions.md +++ b/doc/contributing/first-contributions.md @@ -168,9 +168,11 @@ before approving the CI runs. Similar to the review process, be patient and resp the volunteers' time when you are asking for help to trigger the CI runs, this helps build trust to make future contributions smoother. -Since read access to the Jenkins CI is also restricted, one of the collaborators also will need to -let you know about any failures unless you are a member of one of the platform teams in the Node.js -organisation. If after a day or so from a collaborator triggering a Jenkins CI your PR shows a +### Q: The Jenkins CI failed, but when I clicked the CI link, it shows "Access Denied". What should I do? + +Read access to the Jenkins CI is restricted to a few teams in the Node.js organization. You will +need to ask a member of these teams (for example, any of the collaborators) to show you the details +of the failures. If after a day or so from a collaborator triggering a Jenkins CI your PR shows a failure in either the `node-test-pull-request` or `node-test-commit-*` checks it's worth adding a comment to the PR asking what tests are failed, as the collaborator may not realise that you cannot see the results directly.