fix(rehype-shiki): only import every grammar without a highlighter (#9212)

The plugin imported `index.mjs` statically, and that module imports
every grammar Shiki bundles (`LANGS`) as soon as it's loaded, so a
caller passing its own highlighter still paid for all of them: 260
grammar modules on each thread that loads the plugin. It's now imported
only when the plugin has to create a highlighter itself.

This lets doc-kit, which highlights with a highlighter that loads
grammars on demand, use the plugin rather than a copy of it.

Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>

Author: ovflowd

.changeset/lazy-rehype-shiki-highlighter.md

@@ -0,0 +1,5 @@
+---
+'@node-core/rehype-shiki': patch
+---
+
+Only import every bundled grammar when the plugin isn't given a highlighter

packages/rehype-shiki/src/__tests__/plugin.test.mjs

@@ -1,6 +1,21 @@
 import assert from 'node:assert/strict';
+import { registerHooks } from 'node:module';
 import { describe, it, mock } from 'node:test';
 
+// The modules loaded from here on, to tell whether the default highlighter,
+// which imports every grammar Shiki bundles, was loaded
+const loaded = new Set();
+
+registerHooks({
+  load(url, context, nextLoad) {
+    loaded.add(new URL(url).pathname);
+
+    return nextLoad(url, context);
+  },
+});
+
+const defaultHighlighter = new URL('../index.mjs', import.meta.url).pathname;
+
 // Simplified mocks - only mock what's actually needed
 mock.module('../index.mjs', {
   defaultExport: () => ({ highlightToHast: mock.fn(() => ({ children: [] })) }),
@@ -23,6 +38,15 @@ describe('rehypeShikiji', async () => {
   const { default: rehypeShikiji } = await import('../plugin.mjs');
   const mockTree = { type: 'root', children: [] };
 
+  // Runs first, as the cases after it load the default highlighter
+  it('only loads the default highlighter without a highlighter', async () => {
+    await rehypeShikiji({ highlighter: { highlightToHast: mock.fn() } });
+    assert.ok(!loaded.has(defaultHighlighter));
+
+    await rehypeShikiji();
+    assert.ok(loaded.has(defaultHighlighter));
+  });
+
   it('calls visit twice', async () => {
     mockVisit.mock.resetCalls();
     (await rehypeShikiji())(mockTree);

packages/rehype-shiki/src/plugin.mjs

@@ -4,8 +4,6 @@ import classNames from 'classnames';
 import { toString } from 'hast-util-to-string';
 import { SKIP, visit } from 'unist-util-visit';
 
-import createHighlighter from '#rs/index.mjs';
-
 // This is what Remark will use as prefix within a <pre> className
 // to attribute the current language of the <pre> element
 const languagePrefix = 'language-';
@@ -57,8 +55,15 @@ function isCodeBlock(node) {
  * @param {import('#rs/index.mjs').HighlighterOptions & { highlighter: import('#rs/highlighter.mjs').SyntaxHighlighter }} options
  */
 export default async function rehypeShikiji(options) {
-  const highlighter =
-    options?.highlighter ?? (await createHighlighter(options));
+  let highlighter = options?.highlighter;
+
+  // Loaded only when no highlighter is given, as it imports every grammar
+  // Shiki bundles as soon as it's loaded
+  if (!highlighter) {
+    const { default: createHighlighter } = await import('#rs/index.mjs');
+
+    highlighter = await createHighlighter(options);
+  }
 
   return function (tree) {
     visit(tree, 'element', (_, index, parent) => {