fix(metadata-protocol): add the missing typecheck script and repair all 63 test-layer type errors, graduating the package out of the DEBT ledger (#14018)

* wip: seed-loader import extensions

* wip: seed row type + residual test repairs

* wip: manifest script + DEBT graduation

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: zhuangjianguo

packages/metadata-protocol/package.json

@@ -27,6 +27,7 @@
     "build": "tsup && node ../../scripts/check-dts-emitted.mjs",
     "dev": "tsc --watch",
     "clean": "rm -rf dist",
+    "typecheck": "tsc --noEmit",
     "test": "vitest run",
     "test:watch": "vitest"
   },

packages/metadata-protocol/src/mutation-listeners.test.ts

@@ -20,7 +20,12 @@ function makeProtocol() {
   return new ObjectStackProtocolImplementation({} as any);
 }
 
-const evt = (over: Partial<MetadataMutationEvent> = {}): MetadataMutationEvent => ({
+// `body` mirrors `runMutationProjector`'s own declared parameter
+// (`MetadataMutationEvent & { body?: unknown }`) — the projector cases below
+// pass one, and the bare `Partial<MetadataMutationEvent>` rejected it.
+const evt = (
+  over: Partial<MetadataMutationEvent> & { body?: unknown } = {},
+): MetadataMutationEvent & { body?: unknown } => ({
   type: 'hook',
   name: 'rebind_probe_hook',
   state: 'active',

packages/metadata-protocol/src/protocol.batch-atomic.test.ts

@@ -38,7 +38,10 @@ function makeTransactionalEngine(opts: { driverCanTransact?: boolean } = {}) {
     const rollbacks: unknown[] = [];
     const handle = { id: 'trx-1' };
 
-    const insert = vi.fn(async (_object: string, data: any) => {
+    // Third parameter declared because the write path PASSES it and the
+    // assertions below read `call[2]`: a 2-arity mock made that a tuple
+    // with no element at index 2.
+    const insert = vi.fn(async (_object: string, data: any, _options?: any) => {
         if (data?.title === POISON) throw new Error('insert exploded');
         return { id: `rec-${insert.mock.calls.length}`, ...data };
     });

packages/metadata-protocol/src/protocol.stored-conversions.test.ts

@@ -44,7 +44,12 @@ function matches(r: Row, where: Record<string, unknown>): boolean {
     return true;
 }
 
-function makeStubEngine(seedRows: Array<Partial<Row> & { type: string; name: string; metadata: unknown }>) {
+// `metadata` is `Omit`-ed out of the `Partial<Row>` half, never merely
+// intersected over it: `string & unknown` is `string`, so a plain
+// intersection refuses every body written as an object literal.
+function makeStubEngine(
+    seedRows: Array<Omit<Partial<Row>, 'metadata'> & { type: string; name: string; metadata: unknown }>,
+) {
     let nextId = 0;
     const rows: Row[] = seedRows.map((r) => ({
         id: `r_${++nextId}`,

packages/metadata-protocol/src/protocol.stored-migration.test.ts

@@ -57,7 +57,12 @@ function matches(r: Record<string, any>, where: Record<string, unknown>): boolea
  * actually observable.
  */
 function makeStubEngine(
-    seedRows: Array<Partial<Row> & { type: string; name: string; metadata: unknown }>,
+    // `metadata` is `Omit`-ed out of the `Partial<Row>` half, never merely
+    // intersected over it: on the row `metadata` is the STORED string, and
+    // `string & unknown` is `string`, so a plain intersection refuses every
+    // body written as an object literal — which is the seeding convenience
+    // this harness exists for, and what it already does at runtime below.
+    seedRows: Array<Omit<Partial<Row>, 'metadata'> & { type: string; name: string; metadata: unknown }>,
 ) {
     let nextId = 0;
     const tables = new Map<string, Record<string, any>[]>();

packages/metadata-protocol/src/seed-loader-composite-external-id.test.ts

@@ -1,7 +1,7 @@
 // Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license.
 
 import { describe, it, expect, vi } from 'vitest';
-import { SeedLoaderService } from './seed-loader';
+import { SeedLoaderService } from './seed-loader.js';
 import type { IDataEngine, IMetadataService } from '@objectstack/spec/contracts';
 import { assertEngineDeleteDispatch, assertEngineUpdateDispatch, assertEngineFindOnePredicate } from '@objectstack/metadata-core';
 

packages/metadata-protocol/src/seed-loader-deferred-dropped.test.ts

@@ -1,7 +1,7 @@
 // Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license.
 
 import { describe, it, expect, vi } from 'vitest';
-import { SeedLoaderService } from './seed-loader';
+import { SeedLoaderService } from './seed-loader.js';
 import type { IDataEngine, IMetadataService } from '@objectstack/spec/contracts';
 import { assertEngineDeleteDispatch, assertEngineUpdateDispatch, assertEngineFindOnePredicate } from '@objectstack/metadata-core';
 

packages/metadata-protocol/src/seed-loader-deferred-failure.test.ts

@@ -1,7 +1,7 @@
 // Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license.
 
 import { describe, it, expect, vi } from 'vitest';
-import { SeedLoaderService } from './seed-loader';
+import { SeedLoaderService } from './seed-loader.js';
 import type { IDataEngine, IMetadataService } from '@objectstack/spec/contracts';
 import { assertEngineDeleteDispatch, assertEngineUpdateDispatch, assertEngineFindOnePredicate } from '@objectstack/metadata-core';
 

packages/metadata-protocol/src/seed-loader-engine-schema-fallback.test.ts

@@ -1,7 +1,7 @@
 // Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license.
 
 import { describe, it, expect, vi } from 'vitest';
-import { SeedLoaderService } from './seed-loader';
+import { SeedLoaderService } from './seed-loader.js';
 import type { IDataEngine, IMetadataService } from '@objectstack/spec/contracts';
 import { assertEngineDeleteDispatch, assertEngineUpdateDispatch, assertEngineFindOnePredicate } from '@objectstack/metadata-core';
 

packages/metadata-protocol/src/seed-loader-multi-value-reference.test.ts

@@ -1,7 +1,7 @@
 // Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license.
 
 import { describe, it, expect, vi } from 'vitest';
-import { SeedLoaderService } from './seed-loader';
+import { SeedLoaderService } from './seed-loader.js';
 import type { IDataEngine, IMetadataService } from '@objectstack/spec/contracts';
 import { assertEngineDeleteDispatch, assertEngineUpdateDispatch, assertEngineFindOnePredicate } from '@objectstack/metadata-core';