Skip to content

Commit 1b6fe3f

Browse files
os-muskclaude
andauthored
docs(objectql,cloud-connection): mark the two remaining out-of-repo app paths (#16977)
`apps/cloud` and `apps/objectos-ee` were deleted from this repository and now live in `objectstack-ai/cloud`. Two source comments still named them as live paths here and were in neither of the two earlier censuses. `ObjectQLPluginOptions.skipSchemaSync`'s TSDoc is the main repair: it is an imperative naming `apps/cloud/scripts/migrate.ts`, a script this repo does not contain, and it is the same sentence about the same script as the migrate-and-exit note in `packages/cli/src/commands/serve.ts`. The two were written as a pair and only one had ever been swept, so the marker is copied from that pair verbatim. The `marketplace-install-local-seed-replayer` test's rationale uses the older terse in-repo form, matching the spelling its siblings already use. The objectql docblock is emitted into `dist/index.d.ts` and `dist/index.d.mts`, both inside the published tarball, so it takes a patch changeset. The cloud-connection half publishes nothing — no test file is in that tarball. Claude-Session: https://claude.ai/code/session_01ADLdAs2pVcH17h9tZKWMBg Co-authored-by: Claude <noreply@anthropic.com>
1 parent a72b686 commit 1b6fe3f

3 files changed

Lines changed: 24 additions & 2 deletions

File tree

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
---
2+
"@objectstack/objectql": patch
3+
---
4+
5+
`ObjectQLPluginOptions.skipSchemaSync`'s TSDoc no longer presents `apps/cloud/scripts/migrate.ts` as a path in this repository.
6+
7+
The option's docblock names a concrete script as the out-of-band DDL example:
8+
9+
```ts
10+
* assume DDL is managed out-of-band (e.g. an `apps/cloud/scripts/migrate.ts`
11+
* run before deploy that connects directly to the database and creates
12+
* all `sys_*` + custom tables once).
13+
```
14+
15+
`apps/cloud` was deleted from this repository — the reference cloud host now lives in `objectstack-ai/cloud` — so an unmarked present-tense mention sends a reader looking for a script that is not in the tree they cloned. The referent is genuine, so the sentence is marked rather than re-pointed or deleted.
16+
17+
This ships to consumers: the docblock is emitted into `dist/index.d.ts` and `dist/index.d.mts`, both of which are in the published tarball (`files: ["dist", "README.md", "CHANGELOG.md"]`), so it is the text an IDE shows on `skipSchemaSync`.
18+
19+
The wording is copied from `packages/cli/src/commands/serve.ts`'s migrate-and-exit note, which names the same script and was already marked — the two sentences were written as a pair and only one of them had been swept.
20+
21+
No behaviour changes: the diff is comment text only. No exported symbol, signature, default or runtime path moves.

packages/cloud-connection/src/marketplace-install-local-seed-replayer.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
//
1414
// A runtime that declares no data of its own — `objects: []`, no `data`, which is
1515
// exactly what a marketplace-install target looks like and exactly what
16-
// `apps/objectos-ee` is — therefore ended up with `seed-datasets` POPULATED and
16+
// `apps/objectos-ee` (cloud repo) is — therefore ended up with `seed-datasets` POPULATED and
1717
// `seed-replayer` ABSENT. The org-scoping middleware reads both, finds the
1818
// datasets, finds no replayer, logs `datasets present but no replayer registered`
1919
// and does nothing. Every organization founded after the install boots EMPTY,

packages/objectql/src/plugin.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,8 @@ export interface ObjectQLPluginOptions {
162162
* Skip both `syncRegisteredSchemas()` calls inside `start()` and
163163
* assume DDL is managed out-of-band (e.g. an `apps/cloud/scripts/migrate.ts`
164164
* run before deploy that connects directly to the database and creates
165-
* all `sys_*` + custom tables once).
165+
* all `sys_*` + custom tables once — that script lives in the separate
166+
* `objectstack-ai/cloud` repo and is NOT a path in this one).
166167
*
167168
* Use this on cold-start-sensitive runtimes (Cloudflare Containers,
168169
* Lambda) where the platform's inbound-request budget is shorter than

0 commit comments

Comments
 (0)