Commit 2095e4e
committed
docs(spec): correct the "silent strip" cost statement at all four sites, and re-count clause ② as seven
A CONTRACT_REVIEW_TIER review measured this branch's head and found the cost
statement the maintainer signs off on by merging to be factually wrong. Four
sites said the strip is silent. It is not: `lintUnknownAuthoringKeys` (#3786)
walks every stack collection whose entry schema is strip-mode, and `connectors`
is one, so for `connectors[].syncConfig.schedule` — the one deleted position a
stack manifest reaches — `os validate` and `os build` NAME the dropped key and
`os validate --strict` EXITS 1 on it. Measured at head on an otherwise-clean
stack: without the key 0 warnings / exit 0, with it 1 warning / exit 1.
The truth is more favourable to authors than what the maintainer was told, but
it is not the sentence they were asked to confirm. Corrected at all four sites:
the changeset, `migrations/registry.ts`'s step-18 rationale, two comments in
`cron-typed-positions-retirement.test.ts`, and the PR body's 维护者速读. The
accurate statement is per channel: the PARSE strips silently, `os validate` /
`os build` name the key, `--strict` refuses, `os migrate meta` still lists
nothing.
Same round, two more corrections and no behaviour change:
* Clause ② is SEVEN widenings, not two, and THREE of them are required-key
removals (`ScheduleState.cronExpression`,
`ScheduledExport.schedule.cronExpression`,
`ScheduleExportRequest.schedule.cronExpression`). Measured on both legs:
the five schema files restored to the merge-base on disk, one probe run,
restored to HEAD and re-run, with a byte-identity check after the restore.
14 cases, 14 refusals on the base leg, 14 accept-and-strip on the head leg.
* The changeset now names the departure of the required `cronExpression:
string` member from `ScheduleExportInput` — a published TS interface on
`IExportService`. "No def leaves the public surface" is true and does not
cover a member. Sweep: zero consumers outside `packages/spec`.
⛔ No behaviour changed: the seven deletions, the merge and the ADR-0087
disposition are untouched, and the 直接删 ruling is not re-litigated.
Claude-Session: https://claude.ai/code/session_01MkQhmuuJAVDjmeWNixwDDH
Co-authored-by: Claude <noreply@anthropic.com>1 parent 1504dd1 commit 2095e4e
3 files changed
Lines changed: 87 additions & 18 deletions
File tree
- .changeset
- packages/spec/src
- migrations
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | | - | |
| 28 | + | |
| 29 | + | |
30 | 30 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
35 | 52 | | |
36 | 53 | | |
37 | 54 | | |
| |||
40 | 57 | | |
41 | 58 | | |
42 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
43 | 73 | | |
44 | 74 | | |
45 | 75 | | |
| |||
48 | 78 | | |
49 | 79 | | |
50 | 80 | | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
56 | 88 | | |
57 | 89 | | |
58 | 90 | | |
| |||
Lines changed: 36 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
43 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
44 | 67 | | |
45 | 68 | | |
46 | 69 | | |
| |||
276 | 299 | | |
277 | 300 | | |
278 | 301 | | |
279 | | - | |
280 | | - | |
| 302 | + | |
| 303 | + | |
281 | 304 | | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
282 | 313 | | |
283 | 314 | | |
284 | 315 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5410 | 5410 | | |
5411 | 5411 | | |
5412 | 5412 | | |
5413 | | - | |
5414 | | - | |
| 5413 | + | |
| 5414 | + | |
| 5415 | + | |
| 5416 | + | |
| 5417 | + | |
| 5418 | + | |
| 5419 | + | |
| 5420 | + | |
5415 | 5421 | | |
5416 | 5422 | | |
5417 | 5423 | | |
| |||
0 commit comments