Skip to content

Commit 2676f0f

Browse files
committed
docs(plugin-sharing): state #14547's tracker status accurately in the reverted screens
#14547 is CLOSED as completed — closed by #14949, whose unit half this branch reverts — so calling it "the OPEN defect" in the pins would have been wrong on a checkable fact. The tests name #14547 as the defect they reproduce and say plainly that its tracker state no longer matches the 17.x runtime, leaving the reopen decision to the maintainer rather than asserting it. Comment-only; no assertion, fixture or method body moves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AUF1NoViznQK32gqpK8wS8
1 parent 31430d3 commit 2676f0f

3 files changed

Lines changed: 17 additions & 8 deletions

File tree

packages/plugins/plugin-sharing/src/business-unit-graph.test.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* organization predicate at all — completely unscoped by organization —
1717
* which is the cross-tenant hole #14949 closed and this file still pins.
1818
*
19-
* ## #14547 is OPEN, and these tests reproduce it rather than fix it
19+
* ## #14547's symptom STANDS in 17.x, and these tests reproduce it
2020
*
2121
* #14547 is the external report of the unit half: an org admin creating a rule
2222
* at runtime gets an org-stamped rule, the seeded unit carries no
@@ -28,7 +28,11 @@
2828
* the duplication ADR-0131 exists to retire — and it had not shipped.
2929
*
3030
* So 17.3 behaves exactly as 17.2.0 does here, and the cases below name
31-
* **#14547** as the open defect they reproduce. It is fixed structurally on
31+
* **#14547** as the defect they reproduce. ⚠️ #14547 is CLOSED as completed —
32+
* closed by #14949, whose unit half this reverts — so its GitHub state no
33+
* longer matches the 17.x runtime. Whether it is reopened is the maintainer's
34+
* call, not this file's; what the tests assert is the behaviour, which is
35+
* 17.2.0's. It is fixed structurally on
3236
* the v18 line by ADR-0131 C1 (the Default Organization exists before
3337
* application seed datasets load, and the seed loader stamps
3438
* `sys_business_unit` seeds), so the row this screen reads carries an
@@ -198,7 +202,7 @@ describe('BusinessUnitGraphService — the two widths are actually two widths (#
198202
});
199203

200204
it('[#14547] NEITHER width reaches a SEEDED unit tree, even with stamped members', async () => {
201-
// ⚠️ This reproduces the OPEN defect #14547 — it does not assert a fix.
205+
// ⚠️ This reproduces the defect #14547 reports — it does not assert a fix.
202206
// The membership rows are stamped exactly as a REST/session write stamps
203207
// them, so the MEMBER screen would admit every one of them; the units stay
204208
// seeded, so the strict UNIT screen hides the tree before the member read
@@ -288,10 +292,10 @@ describe('BusinessUnitGraphService — org scoping (#3807)', () => {
288292

289293
/**
290294
* [#14547] The UNIT screen is STRICT — the divergence from `plugin-approvals`
291-
* (#3807) is OPEN, and 17.3 ships it exactly as 17.2.0 did.
295+
* (#3807) STANDS, and 17.3 ships it exactly as 17.2.0 did.
292296
*
293-
* ⚠️ Every case in this block reproduces the OPEN defect **#14547**. None of
294-
* them asserts a fix. #14949 closed the defect by giving this screen the
297+
* ⚠️ Every case in this block reproduces the defect **#14547** reports, which
298+
* 17.x still has. None of them asserts a fix. #14949 closed the defect by giving this screen the
295299
* platform's NULL-inclusive arm; that was reverted before the 17.3 tag
296300
* (ADR-0131 D8) because it wrote `SqlDriver.applyTenantScope`'s own predicate
297301
* a second time, in a second place, and had not shipped. The structural fix is

packages/plugins/plugin-sharing/src/business-unit-graph.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,9 @@ export class BusinessUnitGraphService implements IBusinessUnitGraphService {
298298
*
299299
* #14547 therefore REMAINS as in 17.2.0: an org-stamped rule naming a seeded
300300
* unit expands to nobody. That is a real defect and it is not fixed here.
301+
* (#14547 is CLOSED as completed — by #14949, whose unit half this reverts —
302+
* so its tracker state no longer matches the runtime; reopening it is the
303+
* maintainer's call.)
301304
* Its root cause is the seed loader's `sys_` exemption plus first-boot
302305
* ordering, and it is fixed STRUCTURALLY on the v18 line by ADR-0131 C1 —
303306
* the Default Organization exists before application seed datasets load, and

packages/plugins/plugin-sharing/src/recipient-width.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -362,8 +362,10 @@ describe('#14547 — an org-stamped rule against a SEEDED business unit', () =>
362362
});
363363

364364
/**
365-
* ⚠️ #14547 is OPEN in 17.x and these two cases REPRODUCE it — they do not
366-
* assert a fix. #14949 closed it by widening the unit screen with the
365+
* ⚠️ #14547's symptom stands in 17.x and these two cases REPRODUCE it — they
366+
* do not assert a fix. (#14547 itself is CLOSED as completed, closed by
367+
* #14949 whose unit half this reverts; reopening it is the maintainer's
368+
* call. These tests assert the behaviour, which is 17.2.0's.) #14949 closed it by widening the unit screen with the
367369
* platform's NULL arm; that was reverted before the 17.3 tag (ADR-0131 D8)
368370
* because it re-implemented `SqlDriver.applyTenantScope`'s own predicate a
369371
* second time in a second place, and had not shipped. The structural fix is

0 commit comments

Comments
 (0)