Skip to content

Commit 26e70fb

Browse files
os-steveclaude
andauthored
docs(spec): STORED_TYPE_NOT_CANONICAL ledger comment names both producers and their atomicity (#9411)
The ledger entry at error-code-ledger.zod.ts:381 named only the publish pre-flight as STORED_TYPE_NOT_CANONICAL's producer ("refused at the publish pre-flight, batch-atomic"). PR #9360 (#9174) added a second producer - revertCommit's restore limb, which refuses per-item on its existing failed[] channel and is explicitly NOT batch-atomic - leaving the comment naming one of two producers and the wrong atomicity for the one it omitted. Names both now: the publish pre-flight (batch-atomic, #8908) and revertCommit's restore limb (per-item on failed[], NOT batch-atomic, #9174), verified against the merged #9360 diff at protocol.ts:14432 and protocol.ts:16399. Text-only change - accept/reject behavior, the error code, and its envelope are all unchanged. Fixes #9361 Claude-Session: https://claude.ai/code/session_01Fs18A2DdXLVN2h8PaaFBcP Co-authored-by: Claude <noreply@anthropic.com>
1 parent 83e6016 commit 26e70fb

2 files changed

Lines changed: 18 additions & 1 deletion

File tree

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
---
2+
"@objectstack/spec": patch
3+
---
4+
5+
docs(spec): `STORED_TYPE_NOT_CANONICAL` ledger comment names both producers and their atomicity (#9361)
6+
7+
The ledger entry at `error-code-ledger.zod.ts:381` described `STORED_TYPE_NOT_CANONICAL`'s
8+
only producer as the publish pre-flight ("refused at the publish pre-flight, batch-atomic").
9+
PR #9360 (#9174) added a second producer — `revertCommit`'s restore limb, which refuses
10+
per-item on its existing `failed[]` channel and is explicitly NOT batch-atomic — leaving the
11+
comment naming one of two producers, with the wrong atomicity for the one it omitted.
12+
13+
The comment now names both: the publish pre-flight (batch-atomic, `#8908`) and
14+
`revertCommit`'s restore limb (per-item on `failed[]`, NOT batch-atomic, `#9174`).
15+
16+
Text-only change — accept/reject behavior, the error code, and its envelope are all
17+
unchanged.

packages/spec/src/api/error-code-ledger.zod.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ export const ERROR_CODE_LEDGER = {
378378
'QUERY_OBJECT_MISMATCH',
379379
'REGISTRY_TYPE_NOT_CANONICAL', // [#9111] a SchemaRegistry overlay entry was offered a non-canonical metadata `type` — the mint door asserts, the caller folds
380380
'ROLLED_BACK', // atomic data-batch row was written, then undone by the batch rollback (#4793)
381-
'STORED_TYPE_NOT_CANONICAL', // [#8908] a package draft is stored under a non-canonical metadata type (pre-#7894 second-namespace residue) — refused at the publish pre-flight, batch-atomic
381+
'STORED_TYPE_NOT_CANONICAL', // [#8908] a package draft is stored under a non-canonical metadata type (pre-#7894 second-namespace residue) — refused at the publish pre-flight, batch-atomic; [#9174] also refused on `revertCommit`'s restore limb, per-item on `failed[]`, NOT batch-atomic
382382
'TENANT_SCOPE_REQUIRED', // [#7780] destructive call named neither an organization nor an explicit cross-tenant intent; needs an explicit opt-in
383383
'UNSUPPORTED_QUERY_PARAM',
384384
'VALIDATION_FAILED',

0 commit comments

Comments
 (0)