Skip to content

Commit 3593acd

Browse files
committed
docs(devx): the log-assembly comment names the construct that is actually there
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vbw3RPgdtqesx4azk9SbW8
1 parent a039f1e commit 3593acd

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -638,10 +638,11 @@ jobs:
638638
--report-dir "$RUNNER_TEMP/stall-reports" -- "$@" || { STATUS=$?; break; }
639639
done
640640
641-
# `|| true`, and only over logs that exist: a leg whose guard never got
642-
# far enough to open its log would otherwise make `cat` non-zero, and
643-
# under `set -e` that replaces the SUITE's exit status with cat's — the
644-
# step would report the wrong reason for its own red.
641+
# Only over logs that EXIST, and via an explicit `if` rather than a
642+
# `&&` chain: a leg whose guard never got far enough to open its log
643+
# would otherwise make `cat` non-zero, and under `set -e` that replaces
644+
# the SUITE's exit status with cat's — the step would report the wrong
645+
# reason for its own red.
645646
: > "$RUNNER_TEMP/test-core.log"
646647
for LOG in $LOGS; do
647648
if [ -f "$LOG" ]; then

0 commit comments

Comments
 (0)